Skip to content

L
linux
Commit cbc85a47 authored by Daniel Scheller's avatar Daniel Scheller Committed by Mauro Carvalho Chehab
Browse files
Options

[media] dvb-frontends/cxd2841er: replace IFFREQ calc macros into functions 

The way the MAKE_IFFREQ_CONFIG macros are written make it impossible to
pass regular integers for iffreq calculation, since this will cause "SSE
register return with SSE disabled" compile errors. This changes the
calculation into C functions which also might help when debugging. Also,
expand all passed frequencies from MHz to Hz scale.
Signed-off-by: default avatarDaniel Scheller <d.scheller@gmx.net>
Acked-by: default avatarAbylay Ospan <aospan@netup.ru>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 1ecda28c
Hide whitespace changes
Inline Side-by-side
Showing with 29 additions and 19 deletions
drivers/media/dvb-frontends/cxd2841er.c
View file @ cbc85a47
...@@ -201,11 +201,6 @@ static const struct cxd2841er_cnr_data s2_cn_data[] = { ...@@ -201,11 +201,6 @@ static const struct cxd2841er_cnr_data s2_cn_data[] = {
{ 0x0016, 19700 }, { 0x0015, 19900 }, { 0x0014, 20000 }, { 0x0016, 19700 }, { 0x0015, 19900 }, { 0x0014, 20000 },
}; };
#define MAKE_IFFREQ_CONFIG(iffreq) ((u32)(((iffreq)/41.0)*16777216.0 + 0.5))
#define MAKE_IFFREQ_CONFIG_XTAL(xtal, iffreq) ((xtal == SONY_XTAL_24000) ? \
(u32)(((iffreq)/48.0)*16777216.0 + 0.5) : \
(u32)(((iffreq)/41.0)*16777216.0 + 0.5))
static int cxd2841er_freeze_regs(struct cxd2841er_priv *priv); static int cxd2841er_freeze_regs(struct cxd2841er_priv *priv);
static int cxd2841er_unfreeze_regs(struct cxd2841er_priv *priv); static int cxd2841er_unfreeze_regs(struct cxd2841er_priv *priv);
...@@ -316,6 +311,21 @@ static int cxd2841er_set_reg_bits(struct cxd2841er_priv *priv, ...@@ -316,6 +311,21 @@ static int cxd2841er_set_reg_bits(struct cxd2841er_priv *priv,
return cxd2841er_write_reg(priv, addr, reg, data); return cxd2841er_write_reg(priv, addr, reg, data);
} }
static u32 cxd2841er_calc_iffreq_xtal(enum cxd2841er_xtal xtal, u32 ifhz)
{
u64 tmp;
tmp = (u64) ifhz * 16777216;
do_div(tmp, ((xtal == SONY_XTAL_24000) ? 48000000 : 41000000));
return (u32) tmp;
}
static u32 cxd2841er_calc_iffreq(u32 ifhz)
{
return cxd2841er_calc_iffreq_xtal(SONY_XTAL_20500, ifhz);
}
static int cxd2841er_dvbs2_set_symbol_rate(struct cxd2841er_priv *priv, static int cxd2841er_dvbs2_set_symbol_rate(struct cxd2841er_priv *priv,
u32 symbol_rate) u32 symbol_rate)
{ {
...@@ -2228,7 +2238,7 @@ static int cxd2841er_sleep_tc_to_active_t2_band(struct cxd2841er_priv *priv, ...@@ -2228,7 +2238,7 @@ static int cxd2841er_sleep_tc_to_active_t2_band(struct cxd2841er_priv *priv,
cxd2841er_write_regs(priv, I2C_SLVT, cxd2841er_write_regs(priv, I2C_SLVT,
0xA6, itbCoef8bw[priv->xtal], 14); 0xA6, itbCoef8bw[priv->xtal], 14);
/* <IF freq setting> */ /* <IF freq setting> */
iffreq = MAKE_IFFREQ_CONFIG_XTAL(priv->xtal, 4.80); iffreq = cxd2841er_calc_iffreq_xtal(priv->xtal, 4800000);
data[0] = (u8) ((iffreq >> 16) & 0xff); data[0] = (u8) ((iffreq >> 16) & 0xff);
data[1] = (u8)((iffreq >> 8) & 0xff); data[1] = (u8)((iffreq >> 8) & 0xff);
data[2] = (u8)(iffreq & 0xff); data[2] = (u8)(iffreq & 0xff);
...@@ -2256,7 +2266,7 @@ static int cxd2841er_sleep_tc_to_active_t2_band(struct cxd2841er_priv *priv, ...@@ -2256,7 +2266,7 @@ static int cxd2841er_sleep_tc_to_active_t2_band(struct cxd2841er_priv *priv,
cxd2841er_write_regs(priv, I2C_SLVT, cxd2841er_write_regs(priv, I2C_SLVT,
0xA6, itbCoef7bw[priv->xtal], 14); 0xA6, itbCoef7bw[priv->xtal], 14);
/* <IF freq setting> */ /* <IF freq setting> */
iffreq = MAKE_IFFREQ_CONFIG_XTAL(priv->xtal, 4.20); iffreq = cxd2841er_calc_iffreq_xtal(priv->xtal, 4200000);
data[0] = (u8) ((iffreq >> 16) & 0xff); data[0] = (u8) ((iffreq >> 16) & 0xff);
data[1] = (u8)((iffreq >> 8) & 0xff); data[1] = (u8)((iffreq >> 8) & 0xff);
data[2] = (u8)(iffreq & 0xff); data[2] = (u8)(iffreq & 0xff);
...@@ -2284,7 +2294,7 @@ static int cxd2841er_sleep_tc_to_active_t2_band(struct cxd2841er_priv *priv, ...@@ -2284,7 +2294,7 @@ static int cxd2841er_sleep_tc_to_active_t2_band(struct cxd2841er_priv *priv,
cxd2841er_write_regs(priv, I2C_SLVT, cxd2841er_write_regs(priv, I2C_SLVT,
0xA6, itbCoef6bw[priv->xtal], 14); 0xA6, itbCoef6bw[priv->xtal], 14);
/* <IF freq setting> */ /* <IF freq setting> */
iffreq = MAKE_IFFREQ_CONFIG_XTAL(priv->xtal, 3.60); iffreq = cxd2841er_calc_iffreq_xtal(priv->xtal, 3600000);
data[0] = (u8) ((iffreq >> 16) & 0xff); data[0] = (u8) ((iffreq >> 16) & 0xff);
data[1] = (u8)((iffreq >> 8) & 0xff); data[1] = (u8)((iffreq >> 8) & 0xff);
data[2] = (u8)(iffreq & 0xff); data[2] = (u8)(iffreq & 0xff);
...@@ -2312,7 +2322,7 @@ static int cxd2841er_sleep_tc_to_active_t2_band(struct cxd2841er_priv *priv, ...@@ -2312,7 +2322,7 @@ static int cxd2841er_sleep_tc_to_active_t2_band(struct cxd2841er_priv *priv,
cxd2841er_write_regs(priv, I2C_SLVT, cxd2841er_write_regs(priv, I2C_SLVT,
0xA6, itbCoef5bw[priv->xtal], 14); 0xA6, itbCoef5bw[priv->xtal], 14);
/* <IF freq setting> */ /* <IF freq setting> */
iffreq = MAKE_IFFREQ_CONFIG_XTAL(priv->xtal, 3.60); iffreq = cxd2841er_calc_iffreq_xtal(priv->xtal, 3600000);
data[0] = (u8) ((iffreq >> 16) & 0xff); data[0] = (u8) ((iffreq >> 16) & 0xff);
data[1] = (u8)((iffreq >> 8) & 0xff); data[1] = (u8)((iffreq >> 8) & 0xff);
data[2] = (u8)(iffreq & 0xff); data[2] = (u8)(iffreq & 0xff);
...@@ -2340,7 +2350,7 @@ static int cxd2841er_sleep_tc_to_active_t2_band(struct cxd2841er_priv *priv, ...@@ -2340,7 +2350,7 @@ static int cxd2841er_sleep_tc_to_active_t2_band(struct cxd2841er_priv *priv,
cxd2841er_write_regs(priv, I2C_SLVT, cxd2841er_write_regs(priv, I2C_SLVT,
0xA6, itbCoef17bw[priv->xtal], 14); 0xA6, itbCoef17bw[priv->xtal], 14);
/* <IF freq setting> */ /* <IF freq setting> */
iffreq = MAKE_IFFREQ_CONFIG_XTAL(priv->xtal, 3.50); iffreq = cxd2841er_calc_iffreq_xtal(priv->xtal, 3500000);
data[0] = (u8) ((iffreq >> 16) & 0xff); data[0] = (u8) ((iffreq >> 16) & 0xff);
data[1] = (u8)((iffreq >> 8) & 0xff); data[1] = (u8)((iffreq >> 8) & 0xff);
data[2] = (u8)(iffreq & 0xff); data[2] = (u8)(iffreq & 0xff);
...@@ -2439,7 +2449,7 @@ static int cxd2841er_sleep_tc_to_active_t_band( ...@@ -2439,7 +2449,7 @@ static int cxd2841er_sleep_tc_to_active_t_band(
cxd2841er_write_regs(priv, I2C_SLVT, cxd2841er_write_regs(priv, I2C_SLVT,
0xA6, itbCoef8bw[priv->xtal], 14); 0xA6, itbCoef8bw[priv->xtal], 14);
/* <IF freq setting> */ /* <IF freq setting> */
iffreq = MAKE_IFFREQ_CONFIG_XTAL(priv->xtal, 4.80); iffreq = cxd2841er_calc_iffreq_xtal(priv->xtal, 4800000);
data[0] = (u8) ((iffreq >> 16) & 0xff); data[0] = (u8) ((iffreq >> 16) & 0xff);
data[1] = (u8)((iffreq >> 8) & 0xff); data[1] = (u8)((iffreq >> 8) & 0xff);
data[2] = (u8)(iffreq & 0xff); data[2] = (u8)(iffreq & 0xff);
...@@ -2474,7 +2484,7 @@ static int cxd2841er_sleep_tc_to_active_t_band( ...@@ -2474,7 +2484,7 @@ static int cxd2841er_sleep_tc_to_active_t_band(
cxd2841er_write_regs(priv, I2C_SLVT, cxd2841er_write_regs(priv, I2C_SLVT,
0xA6, itbCoef7bw[priv->xtal], 14); 0xA6, itbCoef7bw[priv->xtal], 14);
/* <IF freq setting> */ /* <IF freq setting> */
iffreq = MAKE_IFFREQ_CONFIG_XTAL(priv->xtal, 4.20); iffreq = cxd2841er_calc_iffreq_xtal(priv->xtal, 4200000);
data[0] = (u8) ((iffreq >> 16) & 0xff); data[0] = (u8) ((iffreq >> 16) & 0xff);
data[1] = (u8)((iffreq >> 8) & 0xff); data[1] = (u8)((iffreq >> 8) & 0xff);
data[2] = (u8)(iffreq & 0xff); data[2] = (u8)(iffreq & 0xff);
...@@ -2509,7 +2519,7 @@ static int cxd2841er_sleep_tc_to_active_t_band( ...@@ -2509,7 +2519,7 @@ static int cxd2841er_sleep_tc_to_active_t_band(
cxd2841er_write_regs(priv, I2C_SLVT, cxd2841er_write_regs(priv, I2C_SLVT,
0xA6, itbCoef6bw[priv->xtal], 14); 0xA6, itbCoef6bw[priv->xtal], 14);
/* <IF freq setting> */ /* <IF freq setting> */
iffreq = MAKE_IFFREQ_CONFIG_XTAL(priv->xtal, 3.60); iffreq = cxd2841er_calc_iffreq_xtal(priv->xtal, 3600000);
data[0] = (u8) ((iffreq >> 16) & 0xff); data[0] = (u8) ((iffreq >> 16) & 0xff);
data[1] = (u8)((iffreq >> 8) & 0xff); data[1] = (u8)((iffreq >> 8) & 0xff);
data[2] = (u8)(iffreq & 0xff); data[2] = (u8)(iffreq & 0xff);
...@@ -2544,7 +2554,7 @@ static int cxd2841er_sleep_tc_to_active_t_band( ...@@ -2544,7 +2554,7 @@ static int cxd2841er_sleep_tc_to_active_t_band(
cxd2841er_write_regs(priv, I2C_SLVT, cxd2841er_write_regs(priv, I2C_SLVT,
0xA6, itbCoef5bw[priv->xtal], 14); 0xA6, itbCoef5bw[priv->xtal], 14);
/* <IF freq setting> */ /* <IF freq setting> */
iffreq = MAKE_IFFREQ_CONFIG_XTAL(priv->xtal, 3.60); iffreq = cxd2841er_calc_iffreq_xtal(priv->xtal, 3600000);
data[0] = (u8) ((iffreq >> 16) & 0xff); data[0] = (u8) ((iffreq >> 16) & 0xff);
data[1] = (u8)((iffreq >> 8) & 0xff); data[1] = (u8)((iffreq >> 8) & 0xff);
data[2] = (u8)(iffreq & 0xff); data[2] = (u8)(iffreq & 0xff);
...@@ -2646,7 +2656,7 @@ static int cxd2841er_sleep_tc_to_active_i_band( ...@@ -2646,7 +2656,7 @@ static int cxd2841er_sleep_tc_to_active_i_band(
0xA6, itbCoef8bw[priv->xtal], 14); 0xA6, itbCoef8bw[priv->xtal], 14);
/* IF freq setting */ /* IF freq setting */
iffreq = MAKE_IFFREQ_CONFIG_XTAL(priv->xtal, 4.75); iffreq = cxd2841er_calc_iffreq_xtal(priv->xtal, 4750000);
data[0] = (u8) ((iffreq >> 16) & 0xff); data[0] = (u8) ((iffreq >> 16) & 0xff);
data[1] = (u8)((iffreq >> 8) & 0xff); data[1] = (u8)((iffreq >> 8) & 0xff);
data[2] = (u8)(iffreq & 0xff); data[2] = (u8)(iffreq & 0xff);
...@@ -2675,7 +2685,7 @@ static int cxd2841er_sleep_tc_to_active_i_band( ...@@ -2675,7 +2685,7 @@ static int cxd2841er_sleep_tc_to_active_i_band(
0xA6, itbCoef7bw[priv->xtal], 14); 0xA6, itbCoef7bw[priv->xtal], 14);
/* IF freq setting */ /* IF freq setting */
iffreq = MAKE_IFFREQ_CONFIG_XTAL(priv->xtal, 4.15); iffreq = cxd2841er_calc_iffreq_xtal(priv->xtal, 4150000);
data[0] = (u8) ((iffreq >> 16) & 0xff); data[0] = (u8) ((iffreq >> 16) & 0xff);
data[1] = (u8)((iffreq >> 8) & 0xff); data[1] = (u8)((iffreq >> 8) & 0xff);
data[2] = (u8)(iffreq & 0xff); data[2] = (u8)(iffreq & 0xff);
...@@ -2704,7 +2714,7 @@ static int cxd2841er_sleep_tc_to_active_i_band( ...@@ -2704,7 +2714,7 @@ static int cxd2841er_sleep_tc_to_active_i_band(
0xA6, itbCoef6bw[priv->xtal], 14); 0xA6, itbCoef6bw[priv->xtal], 14);
/* IF freq setting */ /* IF freq setting */
iffreq = MAKE_IFFREQ_CONFIG_XTAL(priv->xtal, 3.55); iffreq = cxd2841er_calc_iffreq_xtal(priv->xtal, 3550000);
data[0] = (u8) ((iffreq >> 16) & 0xff); data[0] = (u8) ((iffreq >> 16) & 0xff);
data[1] = (u8)((iffreq >> 8) & 0xff); data[1] = (u8)((iffreq >> 8) & 0xff);
data[2] = (u8)(iffreq & 0xff); data[2] = (u8)(iffreq & 0xff);
...@@ -2765,13 +2775,13 @@ static int cxd2841er_sleep_tc_to_active_c_band(struct cxd2841er_priv *priv, ...@@ -2765,13 +2775,13 @@ static int cxd2841er_sleep_tc_to_active_c_band(struct cxd2841er_priv *priv,
cxd2841er_write_regs( cxd2841er_write_regs(
priv, I2C_SLVT, 0xa6, priv, I2C_SLVT, 0xa6,
bw7_8mhz_b10_a6, sizeof(bw7_8mhz_b10_a6)); bw7_8mhz_b10_a6, sizeof(bw7_8mhz_b10_a6));
iffreq = MAKE_IFFREQ_CONFIG(4.9); iffreq = cxd2841er_calc_iffreq(4900000);
break; break;
case 6000000: case 6000000:
cxd2841er_write_regs( cxd2841er_write_regs(
priv, I2C_SLVT, 0xa6, priv, I2C_SLVT, 0xa6,
bw6mhz_b10_a6, sizeof(bw6mhz_b10_a6)); bw6mhz_b10_a6, sizeof(bw6mhz_b10_a6));
iffreq = MAKE_IFFREQ_CONFIG(3.7); iffreq = cxd2841er_calc_iffreq(3700000);
break; break;
default: default:
dev_err(&priv->i2c->dev, "%s(): unsupported bandwidth %d\n", dev_err(&priv->i2c->dev, "%s(): unsupported bandwidth %d\n",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7