Commit cc4598cf authored by Wei Yongjun's avatar Wei Yongjun Committed by David S. Miller

net/fsl: xgmac_mdio: fix return value check in xgmac_mdio_probe()

In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.

Fixes: 1d14eb15 ("net/fsl: xgmac_mdio: Use managed device resources")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: default avatarTobias Waldekranz <tobias@waldekranz.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 47ed9442
...@@ -335,8 +335,8 @@ static int xgmac_mdio_probe(struct platform_device *pdev) ...@@ -335,8 +335,8 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
priv = bus->priv; priv = bus->priv;
priv->mdio_base = devm_ioremap(&pdev->dev, res->start, priv->mdio_base = devm_ioremap(&pdev->dev, res->start,
resource_size(res)); resource_size(res));
if (IS_ERR(priv->mdio_base)) if (!priv->mdio_base)
return PTR_ERR(priv->mdio_base); return -ENOMEM;
/* For both ACPI and DT cases, endianness of MDIO controller /* For both ACPI and DT cases, endianness of MDIO controller
* needs to be specified using "little-endian" property. * needs to be specified using "little-endian" property.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment