Commit cc6f7771 authored by Darrick J. Wong's avatar Darrick J. Wong

xfs: don't unconditionally clear the reflink flag on zero-block files

If we have speculative cow preallocations hanging around in the cow
fork, don't let a truncate operation clear the reflink flag because if
we do then there's a chance we'll forget to free those extents when we
destroy the incore inode.
Reported-by: default avatarAmir Goldstein <amir73il@gmail.com>
Reviewed-by: default avatarCarlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
parent 2bd6bf03
...@@ -1624,10 +1624,12 @@ xfs_itruncate_extents( ...@@ -1624,10 +1624,12 @@ xfs_itruncate_extents(
goto out; goto out;
/* /*
* Clear the reflink flag if we truncated everything. * Clear the reflink flag if there are no data fork blocks and
* there are no extents staged in the cow fork.
*/ */
if (ip->i_d.di_nblocks == 0 && xfs_is_reflink_inode(ip)) { if (xfs_is_reflink_inode(ip) && ip->i_cnextents == 0) {
ip->i_d.di_flags2 &= ~XFS_DIFLAG2_REFLINK; if (ip->i_d.di_nblocks == 0)
ip->i_d.di_flags2 &= ~XFS_DIFLAG2_REFLINK;
xfs_inode_clear_cowblocks_tag(ip); xfs_inode_clear_cowblocks_tag(ip);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment