Commit cce616e0 authored by Yang Yingliang's avatar Yang Yingliang Committed by Jens Wiklander

tee: optee: fix possible memory leak in optee_register_device()

If device_register() returns error in optee_register_device(),
the name allocated by dev_set_name() need be freed. As comment
of device_register() says, it should use put_device() to give
up the reference in the error path. So fix this by calling
put_device(), then the name can be freed in kobject_cleanup(),
and optee_device is freed in optee_release_device().

Fixes: c3fa24af ("tee: optee: add TEE bus device enumeration support")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarSumit Garg <sumit.garg@linaro.org>
Signed-off-by: default avatarJens Wiklander <jens.wiklander@linaro.org>
parent 094226ad
...@@ -80,7 +80,7 @@ static int optee_register_device(const uuid_t *device_uuid) ...@@ -80,7 +80,7 @@ static int optee_register_device(const uuid_t *device_uuid)
rc = device_register(&optee_device->dev); rc = device_register(&optee_device->dev);
if (rc) { if (rc) {
pr_err("device registration failed, err: %d\n", rc); pr_err("device registration failed, err: %d\n", rc);
kfree(optee_device); put_device(&optee_device->dev);
} }
return rc; return rc;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment