Commit ccfecdfe authored by Michal Simek's avatar Michal Simek Committed by David S. Miller

net: emaclite: Report failures in mdio setup

Be more verbose when any problem happens.
Signed-off-by: default avatarMichal Simek <michal.simek@xilinx.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cafe8902
...@@ -852,8 +852,10 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) ...@@ -852,8 +852,10 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev)
/* Don't register the MDIO bus if the phy_node or its parent node /* Don't register the MDIO bus if the phy_node or its parent node
* can't be found. * can't be found.
*/ */
if (!np) if (!np) {
dev_err(dev, "Failed to register mdio bus.\n");
return -ENODEV; return -ENODEV;
}
/* Enable the MDIO bus by asserting the enable bit in MDIO Control /* Enable the MDIO bus by asserting the enable bit in MDIO Control
* register. * register.
...@@ -862,8 +864,10 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) ...@@ -862,8 +864,10 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev)
XEL_MDIOCTRL_MDIOEN_MASK); XEL_MDIOCTRL_MDIOEN_MASK);
bus = mdiobus_alloc(); bus = mdiobus_alloc();
if (!bus) if (!bus) {
dev_err(dev, "Failed to allocal mdiobus\n");
return -ENOMEM; return -ENOMEM;
}
of_address_to_resource(np, 0, &res); of_address_to_resource(np, 0, &res);
snprintf(bus->id, MII_BUS_ID_SIZE, "%.8llx", snprintf(bus->id, MII_BUS_ID_SIZE, "%.8llx",
...@@ -879,8 +883,10 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) ...@@ -879,8 +883,10 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev)
lp->mii_bus = bus; lp->mii_bus = bus;
rc = of_mdiobus_register(bus, np); rc = of_mdiobus_register(bus, np);
if (rc) if (rc) {
dev_err(dev, "Failed to register mdio bus.\n");
goto err_register; goto err_register;
}
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment