Commit cda37445 authored by Su Hui's avatar Su Hui Committed by Kalle Valo

wifi: rtlwifi: rtl8821ae: phy: remove some useless code

Clang static checker warns:

Value stored to 'v1' is never read [deadcode.DeadStores]
Value stored to 'channel' is never read [deadcode.DeadStores]

Remove them to save some place.
Signed-off-by: default avatarSu Hui <suhui@nfschina.com>
Acked-by: default avatarPing-Ke Shih <pkshih@realtek.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20231127013511.26694-1-suhui@nfschina.com
parent ac586b84
...@@ -2038,15 +2038,9 @@ static bool _rtl8821ae_phy_config_bb_with_pgheaderfile(struct ieee80211_hw *hw, ...@@ -2038,15 +2038,9 @@ static bool _rtl8821ae_phy_config_bb_with_pgheaderfile(struct ieee80211_hw *hw,
/*don't need the hw_body*/ /*don't need the hw_body*/
if (!_rtl8821ae_check_condition(hw, v1)) { if (!_rtl8821ae_check_condition(hw, v1)) {
i += 2; /* skip the pair of expression*/ i += 2; /* skip the pair of expression*/
v1 = array[i];
v2 = array[i+1]; v2 = array[i+1];
v3 = array[i+2]; while (v2 != 0xDEAD)
while (v2 != 0xDEAD) {
i += 3; i += 3;
v1 = array[i];
v2 = array[i+1];
v3 = array[i+2];
}
} }
} }
} }
...@@ -3543,7 +3537,6 @@ u8 rtl8821ae_phy_sw_chnl(struct ieee80211_hw *hw) ...@@ -3543,7 +3537,6 @@ u8 rtl8821ae_phy_sw_chnl(struct ieee80211_hw *hw)
struct rtl_phy *rtlphy = &rtlpriv->phy; struct rtl_phy *rtlphy = &rtlpriv->phy;
struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw)); struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
u32 timeout = 1000, timecount = 0; u32 timeout = 1000, timecount = 0;
u8 channel = rtlphy->current_channel;
if (rtlphy->sw_chnl_inprogress) if (rtlphy->sw_chnl_inprogress)
return 0; return 0;
...@@ -3566,8 +3559,6 @@ u8 rtl8821ae_phy_sw_chnl(struct ieee80211_hw *hw) ...@@ -3566,8 +3559,6 @@ u8 rtl8821ae_phy_sw_chnl(struct ieee80211_hw *hw)
rtl8821ae_phy_switch_wirelessband(hw, BAND_ON_2_4G); rtl8821ae_phy_switch_wirelessband(hw, BAND_ON_2_4G);
rtlphy->sw_chnl_inprogress = true; rtlphy->sw_chnl_inprogress = true;
if (channel == 0)
channel = 1;
rtl_dbg(rtlpriv, COMP_SCAN, DBG_TRACE, rtl_dbg(rtlpriv, COMP_SCAN, DBG_TRACE,
"switch to channel%d, band type is %d\n", "switch to channel%d, band type is %d\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment