Commit cdd97383 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jakub Kicinski

net: mvneta: Fix an out of bounds check

In an earlier commit, I added a bounds check to prevent an out of bounds
read and a WARN().  On further discussion and consideration that check
was probably too aggressive.  Instead of returning -EINVAL, a better fix
would be to just prevent the out of bounds read but continue the process.

Background: The value of "pp->rxq_def" is a number between 0-7 by default,
or even higher depending on the value of "rxq_number", which is a module
parameter. If the value is more than the number of available CPUs then
it will trigger the WARN() in cpu_max_bits_warn().

Fixes: e8b4fc13 ("net: mvneta: Prevent out of bounds read in mvneta_config_rss()")
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/Y5A7d1E5ccwHTYPf@kadamSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ed14e590
...@@ -4271,7 +4271,7 @@ static void mvneta_percpu_elect(struct mvneta_port *pp) ...@@ -4271,7 +4271,7 @@ static void mvneta_percpu_elect(struct mvneta_port *pp)
/* Use the cpu associated to the rxq when it is online, in all /* Use the cpu associated to the rxq when it is online, in all
* the other cases, use the cpu 0 which can't be offline. * the other cases, use the cpu 0 which can't be offline.
*/ */
if (cpu_online(pp->rxq_def)) if (pp->rxq_def < nr_cpu_ids && cpu_online(pp->rxq_def))
elected_cpu = pp->rxq_def; elected_cpu = pp->rxq_def;
max_cpu = num_present_cpus(); max_cpu = num_present_cpus();
...@@ -4927,9 +4927,6 @@ static int mvneta_config_rss(struct mvneta_port *pp) ...@@ -4927,9 +4927,6 @@ static int mvneta_config_rss(struct mvneta_port *pp)
napi_disable(&pp->napi); napi_disable(&pp->napi);
} }
if (pp->indir[0] >= nr_cpu_ids)
return -EINVAL;
pp->rxq_def = pp->indir[0]; pp->rxq_def = pp->indir[0];
/* Update unicast mapping */ /* Update unicast mapping */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment