Commit ce52705e authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Herbert Xu

crypto: talitos - Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 88b01c8a
...@@ -3136,7 +3136,7 @@ static int hw_supports(struct device *dev, __be32 desc_hdr_template) ...@@ -3136,7 +3136,7 @@ static int hw_supports(struct device *dev, __be32 desc_hdr_template)
return ret; return ret;
} }
static int talitos_remove(struct platform_device *ofdev) static void talitos_remove(struct platform_device *ofdev)
{ {
struct device *dev = &ofdev->dev; struct device *dev = &ofdev->dev;
struct talitos_private *priv = dev_get_drvdata(dev); struct talitos_private *priv = dev_get_drvdata(dev);
...@@ -3170,8 +3170,6 @@ static int talitos_remove(struct platform_device *ofdev) ...@@ -3170,8 +3170,6 @@ static int talitos_remove(struct platform_device *ofdev)
tasklet_kill(&priv->done_task[0]); tasklet_kill(&priv->done_task[0]);
if (priv->irq[1]) if (priv->irq[1])
tasklet_kill(&priv->done_task[1]); tasklet_kill(&priv->done_task[1]);
return 0;
} }
static struct talitos_crypto_alg *talitos_alg_alloc(struct device *dev, static struct talitos_crypto_alg *talitos_alg_alloc(struct device *dev,
...@@ -3559,7 +3557,7 @@ static struct platform_driver talitos_driver = { ...@@ -3559,7 +3557,7 @@ static struct platform_driver talitos_driver = {
.of_match_table = talitos_match, .of_match_table = talitos_match,
}, },
.probe = talitos_probe, .probe = talitos_probe,
.remove = talitos_remove, .remove_new = talitos_remove,
}; };
module_platform_driver(talitos_driver); module_platform_driver(talitos_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment