Commit ce58e96e authored by Beau Belgrave's avatar Beau Belgrave Committed by Steven Rostedt (Google)

tracing/user_events: Limit global user_event count

Operators want to be able to ensure enough tracepoints exist on the
system for kernel components as well as for user components. Since there
are only up to 64K events, by default allow up to half to be used by
user events.

Add a kernel sysctl parameter (kernel.user_events_max) to set a global
limit that is honored among all groups on the system. This ensures hard
limits can be setup to prevent user processes from consuming all event
IDs on the system.

Link: https://lkml.kernel.org/r/20230328235219.203-12-beaub@linux.microsoft.comSigned-off-by: default avatarBeau Belgrave <beaub@linux.microsoft.com>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent f9cce238
...@@ -20,6 +20,7 @@ ...@@ -20,6 +20,7 @@
#include <linux/types.h> #include <linux/types.h>
#include <linux/uaccess.h> #include <linux/uaccess.h>
#include <linux/highmem.h> #include <linux/highmem.h>
#include <linux/init.h>
#include <linux/user_events.h> #include <linux/user_events.h>
#include "trace.h" #include "trace.h"
#include "trace_dynevent.h" #include "trace_dynevent.h"
...@@ -61,6 +62,12 @@ struct user_event_group { ...@@ -61,6 +62,12 @@ struct user_event_group {
/* Group for init_user_ns mapping, top-most group */ /* Group for init_user_ns mapping, top-most group */
static struct user_event_group *init_group; static struct user_event_group *init_group;
/* Max allowed events for the whole system */
static unsigned int max_user_events = 32768;
/* Current number of events on the whole system */
static unsigned int current_user_events;
/* /*
* Stores per-event properties, as users register events * Stores per-event properties, as users register events
* within a file a user_event might be created if it does not * within a file a user_event might be created if it does not
...@@ -1241,6 +1248,8 @@ static int destroy_user_event(struct user_event *user) ...@@ -1241,6 +1248,8 @@ static int destroy_user_event(struct user_event *user)
{ {
int ret = 0; int ret = 0;
lockdep_assert_held(&event_mutex);
/* Must destroy fields before call removal */ /* Must destroy fields before call removal */
user_event_destroy_fields(user); user_event_destroy_fields(user);
...@@ -1257,6 +1266,11 @@ static int destroy_user_event(struct user_event *user) ...@@ -1257,6 +1266,11 @@ static int destroy_user_event(struct user_event *user)
kfree(EVENT_NAME(user)); kfree(EVENT_NAME(user));
kfree(user); kfree(user);
if (current_user_events > 0)
current_user_events--;
else
pr_alert("BUG: Bad current_user_events\n");
return ret; return ret;
} }
...@@ -1744,6 +1758,11 @@ static int user_event_parse(struct user_event_group *group, char *name, ...@@ -1744,6 +1758,11 @@ static int user_event_parse(struct user_event_group *group, char *name,
mutex_lock(&event_mutex); mutex_lock(&event_mutex);
if (current_user_events >= max_user_events) {
ret = -EMFILE;
goto put_user_lock;
}
ret = user_event_trace_register(user); ret = user_event_trace_register(user);
if (ret) if (ret)
...@@ -1755,6 +1774,7 @@ static int user_event_parse(struct user_event_group *group, char *name, ...@@ -1755,6 +1774,7 @@ static int user_event_parse(struct user_event_group *group, char *name,
dyn_event_init(&user->devent, &user_event_dops); dyn_event_init(&user->devent, &user_event_dops);
dyn_event_add(&user->devent, &user->call); dyn_event_add(&user->devent, &user->call);
hash_add(group->register_table, &user->node, key); hash_add(group->register_table, &user->node, key);
current_user_events++;
mutex_unlock(&event_mutex); mutex_unlock(&event_mutex);
...@@ -2390,6 +2410,31 @@ static int create_user_tracefs(void) ...@@ -2390,6 +2410,31 @@ static int create_user_tracefs(void)
return -ENODEV; return -ENODEV;
} }
static int set_max_user_events_sysctl(struct ctl_table *table, int write,
void *buffer, size_t *lenp, loff_t *ppos)
{
int ret;
mutex_lock(&event_mutex);
ret = proc_douintvec(table, write, buffer, lenp, ppos);
mutex_unlock(&event_mutex);
return ret;
}
static struct ctl_table user_event_sysctls[] = {
{
.procname = "user_events_max",
.data = &max_user_events,
.maxlen = sizeof(unsigned int),
.mode = 0644,
.proc_handler = set_max_user_events_sysctl,
},
{}
};
static int __init trace_events_user_init(void) static int __init trace_events_user_init(void)
{ {
int ret; int ret;
...@@ -2419,6 +2464,8 @@ static int __init trace_events_user_init(void) ...@@ -2419,6 +2464,8 @@ static int __init trace_events_user_init(void)
if (dyn_event_register(&user_event_dops)) if (dyn_event_register(&user_event_dops))
pr_warn("user_events could not register with dyn_events\n"); pr_warn("user_events could not register with dyn_events\n");
register_sysctl_init("kernel", user_event_sysctls);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment