Commit ce74370c authored by Yunsheng Lin's avatar Yunsheng Lin Committed by David S. Miller

net: hns3: optimize the barrier using when cleaning TX BD

Currently, a barrier is used when cleaning each TX BD, which may
cause performance degradation.

This patch optimizes it to use one barrier when cleaning TX BD
each round.
Signed-off-by: default avatarYunsheng Lin <linyunsheng@huawei.com>
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent aa9d22dd
...@@ -2186,20 +2186,25 @@ static void hns3_reuse_buffer(struct hns3_enet_ring *ring, int i) ...@@ -2186,20 +2186,25 @@ static void hns3_reuse_buffer(struct hns3_enet_ring *ring, int i)
ring->desc[i].rx.bd_base_info = 0; ring->desc[i].rx.bd_base_info = 0;
} }
static void hns3_nic_reclaim_one_desc(struct hns3_enet_ring *ring, int *bytes, static void hns3_nic_reclaim_desc(struct hns3_enet_ring *ring, int head,
int *pkts) int *bytes, int *pkts)
{ {
int ntc = ring->next_to_clean; int ntc = ring->next_to_clean;
struct hns3_desc_cb *desc_cb; struct hns3_desc_cb *desc_cb;
desc_cb = &ring->desc_cb[ntc]; while (head != ntc) {
(*pkts) += (desc_cb->type == DESC_TYPE_SKB); desc_cb = &ring->desc_cb[ntc];
(*bytes) += desc_cb->length; (*pkts) += (desc_cb->type == DESC_TYPE_SKB);
/* desc_cb will be cleaned, after hnae3_free_buffer_detach*/ (*bytes) += desc_cb->length;
hns3_free_buffer_detach(ring, ntc); /* desc_cb will be cleaned, after hnae3_free_buffer_detach */
hns3_free_buffer_detach(ring, ntc);
if (++ntc == ring->desc_num) if (++ntc == ring->desc_num)
ntc = 0; ntc = 0;
/* Issue prefetch for next Tx descriptor */
prefetch(&ring->desc_cb[ntc]);
}
/* This smp_store_release() pairs with smp_load_acquire() in /* This smp_store_release() pairs with smp_load_acquire() in
* ring_space called by hns3_nic_net_xmit. * ring_space called by hns3_nic_net_xmit.
...@@ -2244,11 +2249,7 @@ void hns3_clean_tx_ring(struct hns3_enet_ring *ring) ...@@ -2244,11 +2249,7 @@ void hns3_clean_tx_ring(struct hns3_enet_ring *ring)
bytes = 0; bytes = 0;
pkts = 0; pkts = 0;
while (head != ring->next_to_clean) { hns3_nic_reclaim_desc(ring, head, &bytes, &pkts);
hns3_nic_reclaim_one_desc(ring, &bytes, &pkts);
/* Issue prefetch for next Tx descriptor */
prefetch(&ring->desc_cb[ring->next_to_clean]);
}
ring->tqp_vector->tx_group.total_bytes += bytes; ring->tqp_vector->tx_group.total_bytes += bytes;
ring->tqp_vector->tx_group.total_packets += pkts; ring->tqp_vector->tx_group.total_packets += pkts;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment