Commit ce7c47d6 authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Darren Hart (VMware)

platform/x86: fujitsu-laptop: Don't oops when FUJ02E3 is not presnt

My Fujitsu-Siemens Lifebook S6120 doesn't have the FUJ02E3 device,
but it does have FUJ02B1. That means we do register the backlight
device (and it even seems to work), but the code will oops as soon
as we try to set the backlight brightness because it's trying to
call call_fext_func() with a NULL device. Let's just skip those
function calls when the FUJ02E3 device is not present.

Cc: Jonathan Woithe <jwoithe@just42.net>
Cc: Andy Shevchenko <andy@infradead.org>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Cc: <stable@vger.kernel.org> # 4.13.x
Signed-off-by: default avatarDarren Hart (VMware) <dvhart@infradead.org>
parent 2bd6bf03
...@@ -254,10 +254,12 @@ static int bl_update_status(struct backlight_device *b) ...@@ -254,10 +254,12 @@ static int bl_update_status(struct backlight_device *b)
{ {
struct acpi_device *device = bl_get_data(b); struct acpi_device *device = bl_get_data(b);
if (b->props.power == FB_BLANK_POWERDOWN) if (fext) {
call_fext_func(fext, FUNC_BACKLIGHT, 0x1, 0x4, 0x3); if (b->props.power == FB_BLANK_POWERDOWN)
else call_fext_func(fext, FUNC_BACKLIGHT, 0x1, 0x4, 0x3);
call_fext_func(fext, FUNC_BACKLIGHT, 0x1, 0x4, 0x0); else
call_fext_func(fext, FUNC_BACKLIGHT, 0x1, 0x4, 0x0);
}
return set_lcd_level(device, b->props.brightness); return set_lcd_level(device, b->props.brightness);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment