Commit cec6dba2 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Bjorn Helgaas

PCI: xilinx: Fix return value in case of error

In xilinx_pcie_init_irq_domain(), the pattern used to check and return
error is:

   if (!var) {
      dev_err(...);
      return PTR_ERR(var);
   }

So the returned value in case of error is always 0, which means 'success'.
Change it to return -ENODEV instead.
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarSören Brinkmann <soren.brinkmann@xilinx.com>
parent af8c34ce
...@@ -550,7 +550,7 @@ static int xilinx_pcie_init_irq_domain(struct xilinx_pcie_port *port) ...@@ -550,7 +550,7 @@ static int xilinx_pcie_init_irq_domain(struct xilinx_pcie_port *port)
pcie_intc_node = of_get_next_child(node, NULL); pcie_intc_node = of_get_next_child(node, NULL);
if (!pcie_intc_node) { if (!pcie_intc_node) {
dev_err(dev, "No PCIe Intc node found\n"); dev_err(dev, "No PCIe Intc node found\n");
return PTR_ERR(pcie_intc_node); return -ENODEV;
} }
port->irq_domain = irq_domain_add_linear(pcie_intc_node, 4, port->irq_domain = irq_domain_add_linear(pcie_intc_node, 4,
...@@ -558,7 +558,7 @@ static int xilinx_pcie_init_irq_domain(struct xilinx_pcie_port *port) ...@@ -558,7 +558,7 @@ static int xilinx_pcie_init_irq_domain(struct xilinx_pcie_port *port)
port); port);
if (!port->irq_domain) { if (!port->irq_domain) {
dev_err(dev, "Failed to get a INTx IRQ domain\n"); dev_err(dev, "Failed to get a INTx IRQ domain\n");
return PTR_ERR(port->irq_domain); return -ENODEV;
} }
/* Setup MSI */ /* Setup MSI */
...@@ -569,7 +569,7 @@ static int xilinx_pcie_init_irq_domain(struct xilinx_pcie_port *port) ...@@ -569,7 +569,7 @@ static int xilinx_pcie_init_irq_domain(struct xilinx_pcie_port *port)
&xilinx_pcie_msi_chip); &xilinx_pcie_msi_chip);
if (!port->irq_domain) { if (!port->irq_domain) {
dev_err(dev, "Failed to get a MSI IRQ domain\n"); dev_err(dev, "Failed to get a MSI IRQ domain\n");
return PTR_ERR(port->irq_domain); return -ENODEV;
} }
xilinx_pcie_enable_msi(port); xilinx_pcie_enable_msi(port);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment