Commit ced7a04e authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller

pkt_sched: fq: increase max delay from 125 ms to one second

FQ/pacing has a clamp of delay of 125 ms, to avoid some possible harm.

It turns out this delay is too small to allow pacing low rates :
Some ISP setup very aggressive policers as low as 16kbit.

Now TCP stack has spurious rtx prevention, it seems safe to increase
this fixed parameter, without adding a qdisc attribute.
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d3fc6b3f
...@@ -481,12 +481,11 @@ static struct sk_buff *fq_dequeue(struct Qdisc *sch) ...@@ -481,12 +481,11 @@ static struct sk_buff *fq_dequeue(struct Qdisc *sch)
if (likely(rate)) if (likely(rate))
do_div(len, rate); do_div(len, rate);
/* Since socket rate can change later, /* Since socket rate can change later,
* clamp the delay to 125 ms. * clamp the delay to 1 second.
* TODO: maybe segment the too big skb, as in commit * Really, providers of too big packets should be fixed !
* e43ac79a4bc ("sch_tbf: segment too big GSO packets")
*/ */
if (unlikely(len > 125 * NSEC_PER_MSEC)) { if (unlikely(len > NSEC_PER_SEC)) {
len = 125 * NSEC_PER_MSEC; len = NSEC_PER_SEC;
q->stat_pkts_too_long++; q->stat_pkts_too_long++;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment