Commit cf536e18 authored by Feng Tang's avatar Feng Tang Committed by Masahiro Yamada

Makefile: extend 32B aligned debug option to 64B aligned

Commit 09c60546 ("./Makefile: add debug option to enable
function aligned on 32 bytes") was introduced to help debugging
strange kernel performance changes caused by code alignment
change.

Recently we found 2 similar cases [1][2] caused by code-alignment
changes, which can only be identified by forcing 64 bytes aligned
for all functions.

Originally, 32 bytes was used mainly for not wasting too much
text space, but this option is only for debug anyway where text
space is not a big concern. So extend the alignment to 64 bytes
to cover more similar cases.

[1].https://lore.kernel.org/lkml/20210427090013.GG32408@xsang-OptiPlex-9020/
[2].https://lore.kernel.org/lkml/20210420030837.GB31773@xsang-OptiPlex-9020/Signed-off-by: default avatarFeng Tang <feng.tang@intel.com>
Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
parent c4681547
...@@ -953,8 +953,8 @@ KBUILD_CFLAGS += $(CC_FLAGS_CFI) ...@@ -953,8 +953,8 @@ KBUILD_CFLAGS += $(CC_FLAGS_CFI)
export CC_FLAGS_CFI export CC_FLAGS_CFI
endif endif
ifdef CONFIG_DEBUG_FORCE_FUNCTION_ALIGN_32B ifdef CONFIG_DEBUG_FORCE_FUNCTION_ALIGN_64B
KBUILD_CFLAGS += -falign-functions=32 KBUILD_CFLAGS += -falign-functions=64
endif endif
# arch Makefile may override CC so keep this after arch Makefile is included # arch Makefile may override CC so keep this after arch Makefile is included
......
...@@ -400,8 +400,8 @@ config SECTION_MISMATCH_WARN_ONLY ...@@ -400,8 +400,8 @@ config SECTION_MISMATCH_WARN_ONLY
If unsure, say Y. If unsure, say Y.
config DEBUG_FORCE_FUNCTION_ALIGN_32B config DEBUG_FORCE_FUNCTION_ALIGN_64B
bool "Force all function address 32B aligned" if EXPERT bool "Force all function address 64B aligned" if EXPERT
help help
There are cases that a commit from one domain changes the function There are cases that a commit from one domain changes the function
address alignment of other domains, and cause magic performance address alignment of other domains, and cause magic performance
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment