Commit d03025ae authored by Bart Van Assche's avatar Bart Van Assche Committed by Jens Axboe

fs/xfs: Use the enum req_op and blk_opf_t types

Improve static type checking by using the enum req_op type for variables
that represent a request operation and the new blk_opf_t type for the
combination of a request operation with request flags.
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20220714180729.1065367-63-bvanassche@acm.orgSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 568e34ed
...@@ -15,7 +15,7 @@ xfs_rw_bdev( ...@@ -15,7 +15,7 @@ xfs_rw_bdev(
sector_t sector, sector_t sector,
unsigned int count, unsigned int count,
char *data, char *data,
unsigned int op) enum req_op op)
{ {
unsigned int is_vmalloc = is_vmalloc_addr(data); unsigned int is_vmalloc = is_vmalloc_addr(data);
......
...@@ -1416,7 +1416,7 @@ xfs_buf_ioapply_map( ...@@ -1416,7 +1416,7 @@ xfs_buf_ioapply_map(
int map, int map,
int *buf_offset, int *buf_offset,
int *count, int *count,
int op) blk_opf_t op)
{ {
int page_index; int page_index;
unsigned int total_nr_pages = bp->b_page_count; unsigned int total_nr_pages = bp->b_page_count;
...@@ -1493,7 +1493,7 @@ _xfs_buf_ioapply( ...@@ -1493,7 +1493,7 @@ _xfs_buf_ioapply(
struct xfs_buf *bp) struct xfs_buf *bp)
{ {
struct blk_plug plug; struct blk_plug plug;
int op; blk_opf_t op;
int offset; int offset;
int size; int size;
int i; int i;
......
...@@ -196,7 +196,7 @@ static inline uint64_t howmany_64(uint64_t x, uint32_t y) ...@@ -196,7 +196,7 @@ static inline uint64_t howmany_64(uint64_t x, uint32_t y)
} }
int xfs_rw_bdev(struct block_device *bdev, sector_t sector, unsigned int count, int xfs_rw_bdev(struct block_device *bdev, sector_t sector, unsigned int count,
char *data, unsigned int op); char *data, enum req_op op);
#define ASSERT_ALWAYS(expr) \ #define ASSERT_ALWAYS(expr) \
(likely(expr) ? (void)0 : assfail(NULL, #expr, __FILE__, __LINE__)) (likely(expr) ? (void)0 : assfail(NULL, #expr, __FILE__, __LINE__))
......
...@@ -122,7 +122,7 @@ xlog_do_io( ...@@ -122,7 +122,7 @@ xlog_do_io(
xfs_daddr_t blk_no, xfs_daddr_t blk_no,
unsigned int nbblks, unsigned int nbblks,
char *data, char *data,
unsigned int op) enum req_op op)
{ {
int error; int error;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment