Commit d04863e9 authored by Brad Sawatzky's avatar Brad Sawatzky Committed by Greg Kroah-Hartman

USB: serial: fix regression in Visor/Palm OS module for kernels >= 2.6.24

Fixes a bug/inconsistency revealed by the additional sanity checking in
   commit 063a2da8
introduced in the original 2.6.24 branch.

The Handspring Visor / PalmOS 4 device structure defines .num_bulk_out=2
but the usb-serial probe returns num_bulk_out=3, triggering the check in
the above commit and forcing a bail out when the device (a Garmin iQue in
my case) attempts to connect.  The patch bumps the expected number of
endpoints to 3.

FWIW, this patch will probably solve the following kernel bug report for
Treo users (identical symptoms, different model PalmOS units):
  <http://bugzilla.kernel.org/show_bug.cgi?id=10118>
Signed-off-by: default avatarBrad Sawatzky <brad+kernel@swatter.net>
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent e8898681
...@@ -191,7 +191,7 @@ static struct usb_serial_driver handspring_device = { ...@@ -191,7 +191,7 @@ static struct usb_serial_driver handspring_device = {
.id_table = id_table, .id_table = id_table,
.num_interrupt_in = NUM_DONT_CARE, .num_interrupt_in = NUM_DONT_CARE,
.num_bulk_in = 2, .num_bulk_in = 2,
.num_bulk_out = 2, .num_bulk_out = NUM_DONT_CARE,
.num_ports = 2, .num_ports = 2,
.open = visor_open, .open = visor_open,
.close = visor_close, .close = visor_close,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment