Commit d17a18dd authored by Dave Young's avatar Dave Young Committed by Linus Torvalds

pktcdvd: add kobject_put when kobject register fails

In kobject_register, the kobject reference is get in kobject_init, and then
kobject_add.  If kobject_add fail, it will only cleanup the reference got
by itself.
Signed-off-by: default avatarDave Young <hidave.darkstar@gmail.com>
Reviewed-by: default avatarPekka Enberg <penberg@cs.helsinki.fi>
Cc: Greg KH <greg@kroah.com>
Cc: Peter Osterlund <petero2@telia.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent bbd06825
...@@ -117,8 +117,10 @@ static struct pktcdvd_kobj* pkt_kobj_create(struct pktcdvd_device *pd, ...@@ -117,8 +117,10 @@ static struct pktcdvd_kobj* pkt_kobj_create(struct pktcdvd_device *pd,
p->kobj.parent = parent; p->kobj.parent = parent;
p->kobj.ktype = ktype; p->kobj.ktype = ktype;
p->pd = pd; p->pd = pd;
if (kobject_register(&p->kobj) != 0) if (kobject_register(&p->kobj) != 0) {
kobject_put(&p->kobj);
return NULL; return NULL;
}
return p; return p;
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment