Commit d1bda904 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Hans de Goede

platform/x86: compal-laptop: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230302144732.1903781-9-u.kleine-koenig@pengutronix.deReviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent f4278cc8
...@@ -1003,12 +1003,12 @@ static int compal_probe(struct platform_device *pdev) ...@@ -1003,12 +1003,12 @@ static int compal_probe(struct platform_device *pdev)
return err; return err;
} }
static int compal_remove(struct platform_device *pdev) static void compal_remove(struct platform_device *pdev)
{ {
struct compal_data *data; struct compal_data *data;
if (!extra_features) if (!extra_features)
return 0; return;
pr_info("Unloading: resetting fan control to motherboard\n"); pr_info("Unloading: resetting fan control to motherboard\n");
pwm_disable_control(); pwm_disable_control();
...@@ -1017,8 +1017,6 @@ static int compal_remove(struct platform_device *pdev) ...@@ -1017,8 +1017,6 @@ static int compal_remove(struct platform_device *pdev)
power_supply_unregister(data->psy); power_supply_unregister(data->psy);
sysfs_remove_group(&pdev->dev.kobj, &compal_platform_attr_group); sysfs_remove_group(&pdev->dev.kobj, &compal_platform_attr_group);
return 0;
} }
static struct platform_driver compal_driver = { static struct platform_driver compal_driver = {
...@@ -1026,7 +1024,7 @@ static struct platform_driver compal_driver = { ...@@ -1026,7 +1024,7 @@ static struct platform_driver compal_driver = {
.name = DRIVER_NAME, .name = DRIVER_NAME,
}, },
.probe = compal_probe, .probe = compal_probe,
.remove = compal_remove, .remove_new = compal_remove,
}; };
static int __init compal_init(void) static int __init compal_init(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment