Commit d2249bf2 authored by Jing Xiangfeng's avatar Jing Xiangfeng Committed by Stephen Boyd

clk: qcom: lpass: Correct goto target in lpass_core_sc7180_probe()

lpass_core_sc7180_probe() misses to call pm_clk_destroy() and
pm_runtime_disable() in error paths. Correct goto target to fix it.
This issue is found by code inspection.
Signed-off-by: default avatarJing Xiangfeng <jingxiangfeng@huawei.com>
Link: https://lore.kernel.org/r/20200827141629.101802-1-jingxiangfeng@huawei.com
Fixes: edab812d ("clk: qcom: lpass: Add support for LPASS clock controller for SC7180")
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent da9c43dc
...@@ -420,17 +420,18 @@ static int lpass_core_sc7180_probe(struct platform_device *pdev) ...@@ -420,17 +420,18 @@ static int lpass_core_sc7180_probe(struct platform_device *pdev)
pm_runtime_enable(&pdev->dev); pm_runtime_enable(&pdev->dev);
ret = pm_clk_create(&pdev->dev); ret = pm_clk_create(&pdev->dev);
if (ret) if (ret)
return ret; goto disable_pm_runtime;
ret = pm_clk_add(&pdev->dev, "iface"); ret = pm_clk_add(&pdev->dev, "iface");
if (ret < 0) { if (ret < 0) {
dev_err(&pdev->dev, "failed to acquire iface clock\n"); dev_err(&pdev->dev, "failed to acquire iface clock\n");
goto disable_pm_runtime; goto destroy_pm_clk;
} }
ret = -EINVAL;
clk_probe = of_device_get_match_data(&pdev->dev); clk_probe = of_device_get_match_data(&pdev->dev);
if (!clk_probe) if (!clk_probe)
return -EINVAL; goto destroy_pm_clk;
ret = clk_probe(pdev); ret = clk_probe(pdev);
if (ret) if (ret)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment