Commit d31472b6 authored by Roland McGrath's avatar Roland McGrath Committed by Linus Torvalds

core dump: user_regset writeback

This makes the user_regset-based core dump code call user_regset writeback
hooks when available.  This is necessary groundwork to allow IA64 to set
CORE_DUMP_USE_REGSET.

Cc: Shaohua Li <shaohua.li@intel.com>
Signed-off-by: default avatarRoland McGrath <roland@redhat.com>
Cc: "Luck, Tony" <tony.luck@intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 938a9204
...@@ -1424,6 +1424,18 @@ struct elf_note_info { ...@@ -1424,6 +1424,18 @@ struct elf_note_info {
int thread_notes; int thread_notes;
}; };
/*
* When a regset has a writeback hook, we call it on each thread before
* dumping user memory. On register window machines, this makes sure the
* user memory backing the register data is up to date before we read it.
*/
static void do_thread_regset_writeback(struct task_struct *task,
const struct user_regset *regset)
{
if (regset->writeback)
regset->writeback(task, regset, 1);
}
static int fill_thread_core_info(struct elf_thread_core_info *t, static int fill_thread_core_info(struct elf_thread_core_info *t,
const struct user_regset_view *view, const struct user_regset_view *view,
long signr, size_t *total) long signr, size_t *total)
...@@ -1445,6 +1457,8 @@ static int fill_thread_core_info(struct elf_thread_core_info *t, ...@@ -1445,6 +1457,8 @@ static int fill_thread_core_info(struct elf_thread_core_info *t,
sizeof(t->prstatus), &t->prstatus); sizeof(t->prstatus), &t->prstatus);
*total += notesize(&t->notes[0]); *total += notesize(&t->notes[0]);
do_thread_regset_writeback(t->task, &view->regsets[0]);
/* /*
* Each other regset might generate a note too. For each regset * Each other regset might generate a note too. For each regset
* that has no core_note_type or is inactive, we leave t->notes[i] * that has no core_note_type or is inactive, we leave t->notes[i]
...@@ -1452,6 +1466,7 @@ static int fill_thread_core_info(struct elf_thread_core_info *t, ...@@ -1452,6 +1466,7 @@ static int fill_thread_core_info(struct elf_thread_core_info *t,
*/ */
for (i = 1; i < view->n; ++i) { for (i = 1; i < view->n; ++i) {
const struct user_regset *regset = &view->regsets[i]; const struct user_regset *regset = &view->regsets[i];
do_thread_regset_writeback(t->task, regset);
if (regset->core_note_type && if (regset->core_note_type &&
(!regset->active || regset->active(t->task, regset))) { (!regset->active || regset->active(t->task, regset))) {
int ret; int ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment