Commit d327a224 authored by Jacopo Mondi's avatar Jacopo Mondi Committed by Linus Walleij

tools: gpio: Print error string on IOCTL failures

Add to error messages the error description by concatenating
output of strerror() function to error messages print out by
gpio-utils.c on IOCTL failures.
Rationalize error messages, while at there, making all of them
look the same.
Signed-off-by: default avatarJacopo Mondi <jacopo+renesas@jmondi.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent a3c12952
...@@ -76,7 +76,8 @@ int gpiotools_request_linehandle(const char *device_name, unsigned int *lines, ...@@ -76,7 +76,8 @@ int gpiotools_request_linehandle(const char *device_name, unsigned int *lines,
fd = open(chrdev_name, 0); fd = open(chrdev_name, 0);
if (fd == -1) { if (fd == -1) {
ret = -errno; ret = -errno;
fprintf(stderr, "Failed to open %s\n", chrdev_name); fprintf(stderr, "Failed to open %s, %s\n",
chrdev_name, strerror(errno));
goto exit_close_error; goto exit_close_error;
} }
...@@ -92,8 +93,8 @@ int gpiotools_request_linehandle(const char *device_name, unsigned int *lines, ...@@ -92,8 +93,8 @@ int gpiotools_request_linehandle(const char *device_name, unsigned int *lines,
ret = ioctl(fd, GPIO_GET_LINEHANDLE_IOCTL, &req); ret = ioctl(fd, GPIO_GET_LINEHANDLE_IOCTL, &req);
if (ret == -1) { if (ret == -1) {
ret = -errno; ret = -errno;
fprintf(stderr, "Failed to issue GET LINEHANDLE IOCTL (%d)\n", fprintf(stderr, "Failed to issue %s (%d), %s\n",
ret); "GPIO_GET_LINEHANDLE_IOCTL", ret, strerror(errno));
} }
exit_close_error: exit_close_error:
...@@ -118,8 +119,9 @@ int gpiotools_set_values(const int fd, struct gpiohandle_data *data) ...@@ -118,8 +119,9 @@ int gpiotools_set_values(const int fd, struct gpiohandle_data *data)
ret = ioctl(fd, GPIOHANDLE_SET_LINE_VALUES_IOCTL, data); ret = ioctl(fd, GPIOHANDLE_SET_LINE_VALUES_IOCTL, data);
if (ret == -1) { if (ret == -1) {
ret = -errno; ret = -errno;
fprintf(stderr, "Failed to issue %s (%d)\n", fprintf(stderr, "Failed to issue %s (%d), %s\n",
"GPIOHANDLE_SET_LINE_VALUES_IOCTL", ret); "GPIOHANDLE_SET_LINE_VALUES_IOCTL", ret,
strerror(errno));
} }
return ret; return ret;
...@@ -141,8 +143,9 @@ int gpiotools_get_values(const int fd, struct gpiohandle_data *data) ...@@ -141,8 +143,9 @@ int gpiotools_get_values(const int fd, struct gpiohandle_data *data)
ret = ioctl(fd, GPIOHANDLE_GET_LINE_VALUES_IOCTL, data); ret = ioctl(fd, GPIOHANDLE_GET_LINE_VALUES_IOCTL, data);
if (ret == -1) { if (ret == -1) {
ret = -errno; ret = -errno;
fprintf(stderr, "Failed to issue %s (%d)\n", fprintf(stderr, "Failed to issue %s (%d), %s\n",
"GPIOHANDLE_GET_LINE_VALUES_IOCTL", ret); "GPIOHANDLE_GET_LINE_VALUES_IOCTL", ret,
strerror(errno));
} }
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment