Commit d3383aaa authored by Colin Ian King's avatar Colin Ian King Committed by Michael Ellerman

cxl: remove redundant increment of hwirq

hwirq has not been initialized, however it is being incremented
and also not being referenced in a loop.  This error was detected with
cppcheck:

[drivers/misc/cxl/irq.c:439]: (error) Uninitialized variable: hwirq

Commit 80fa93fc ("cxl: Name interrupts in /proc/interrupt")
introduced this error.

This is a simple fix that removes the redundant increment.
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-By: default avatarIan Munsie <imunsie@au1.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent d83fb87b
...@@ -436,7 +436,7 @@ int afu_register_irqs(struct cxl_context *ctx, u32 count) ...@@ -436,7 +436,7 @@ int afu_register_irqs(struct cxl_context *ctx, u32 count)
*/ */
INIT_LIST_HEAD(&ctx->irq_names); INIT_LIST_HEAD(&ctx->irq_names);
for (r = 1; r < CXL_IRQ_RANGES; r++) { for (r = 1; r < CXL_IRQ_RANGES; r++) {
for (i = 0; i < ctx->irqs.range[r]; hwirq++, i++) { for (i = 0; i < ctx->irqs.range[r]; i++) {
irq_name = kmalloc(sizeof(struct cxl_irq_name), irq_name = kmalloc(sizeof(struct cxl_irq_name),
GFP_KERNEL); GFP_KERNEL);
if (!irq_name) if (!irq_name)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment