Commit d3dd4480 authored by Alan Jenkins's avatar Alan Jenkins Committed by Andy Shevchenko

platform/x86: fujitsu-laptop: replace numeric values with constants

Replace three repeating numeric values with constants to improve code
clarity.
Signed-off-by: default avatarAlan Jenkins <alan-jenkins@tuffmail.co.uk>
[kempniu: rebase patch, rewrite commit message]
Signed-off-by: default avatarMichał Kępień <kernel@kempniu.pl>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarJonathan Woithe <jwoithe@just42.net>
parent 8ef27bd3
...@@ -97,6 +97,11 @@ ...@@ -97,6 +97,11 @@
/* FUNC interface - responses */ /* FUNC interface - responses */
#define UNSUPPORTED_CMD 0x80000000 #define UNSUPPORTED_CMD 0x80000000
/* FUNC interface - status flags */
#define FLAG_RFKILL 0x020
#define FLAG_LID 0x100
#define FLAG_DOCK 0x200
#if IS_ENABLED(CONFIG_LEDS_CLASS) #if IS_ENABLED(CONFIG_LEDS_CLASS)
/* FUNC interface - LED control */ /* FUNC interface - LED control */
#define FUNC_LED_OFF 0x1 #define FUNC_LED_OFF 0x1
...@@ -567,9 +572,9 @@ static ssize_t ...@@ -567,9 +572,9 @@ static ssize_t
show_lid_state(struct device *dev, show_lid_state(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
if (!(fujitsu_laptop->flags_supported & 0x100)) if (!(fujitsu_laptop->flags_supported & FLAG_LID))
return sprintf(buf, "unknown\n"); return sprintf(buf, "unknown\n");
if (fujitsu_laptop->flags_state & 0x100) if (fujitsu_laptop->flags_state & FLAG_LID)
return sprintf(buf, "open\n"); return sprintf(buf, "open\n");
else else
return sprintf(buf, "closed\n"); return sprintf(buf, "closed\n");
...@@ -579,9 +584,9 @@ static ssize_t ...@@ -579,9 +584,9 @@ static ssize_t
show_dock_state(struct device *dev, show_dock_state(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
if (!(fujitsu_laptop->flags_supported & 0x200)) if (!(fujitsu_laptop->flags_supported & FLAG_DOCK))
return sprintf(buf, "unknown\n"); return sprintf(buf, "unknown\n");
if (fujitsu_laptop->flags_state & 0x200) if (fujitsu_laptop->flags_state & FLAG_DOCK)
return sprintf(buf, "docked\n"); return sprintf(buf, "docked\n");
else else
return sprintf(buf, "undocked\n"); return sprintf(buf, "undocked\n");
...@@ -591,9 +596,9 @@ static ssize_t ...@@ -591,9 +596,9 @@ static ssize_t
show_radios_state(struct device *dev, show_radios_state(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
if (!(fujitsu_laptop->flags_supported & 0x20)) if (!(fujitsu_laptop->flags_supported & FLAG_RFKILL))
return sprintf(buf, "unknown\n"); return sprintf(buf, "unknown\n");
if (fujitsu_laptop->flags_state & 0x20) if (fujitsu_laptop->flags_state & FLAG_RFKILL)
return sprintf(buf, "on\n"); return sprintf(buf, "on\n");
else else
return sprintf(buf, "killed\n"); return sprintf(buf, "killed\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment