Commit d50b86b3 authored by Colin Ian King's avatar Colin Ian King Committed by Mark Brown

ASoC: rk817: remove redundant assignment to pointer node, add missing of_node_put

The pointer node is being initialized with a value that is never read and
it is being updated later with a new value.  The initialization is
redundant and can be removed.

The function is missing a of_node_put on node, fix this by adding the call
before returning.

Addresses-Coverity: ("Unused value")
Fixes: 0d6a04da ("ASoC: Add Rockchip rk817 audio CODEC support")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Tested-by: default avatarChris Morgan <macromorgan@hotmail.com>
Link: https://lore.kernel.org/r/20210603113659.82031-1-colin.king@canonical.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 54f67313
...@@ -457,7 +457,7 @@ static const struct snd_soc_component_driver soc_codec_dev_rk817 = { ...@@ -457,7 +457,7 @@ static const struct snd_soc_component_driver soc_codec_dev_rk817 = {
static void rk817_codec_parse_dt_property(struct device *dev, static void rk817_codec_parse_dt_property(struct device *dev,
struct rk817_codec_priv *rk817) struct rk817_codec_priv *rk817)
{ {
struct device_node *node = dev->parent->of_node; struct device_node *node;
node = of_get_child_by_name(dev->parent->of_node, "codec"); node = of_get_child_by_name(dev->parent->of_node, "codec");
if (!node) { if (!node) {
...@@ -467,6 +467,8 @@ static void rk817_codec_parse_dt_property(struct device *dev, ...@@ -467,6 +467,8 @@ static void rk817_codec_parse_dt_property(struct device *dev,
rk817->mic_in_differential = rk817->mic_in_differential =
of_property_read_bool(node, "rockchip,mic-in-differential"); of_property_read_bool(node, "rockchip,mic-in-differential");
of_node_put(node);
} }
static int rk817_platform_probe(struct platform_device *pdev) static int rk817_platform_probe(struct platform_device *pdev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment