Commit d5359226 authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Walleij

gpio: mvebu: make mvchip->irqbase signed for error handling

There is a bug in mvebu_gpio_probe() where we do:

	mvchip->irqbase = irq_alloc_descs(-1, 0, ngpios, -1);
	if (mvchip->irqbase < 0) {

The problem is that mvchip->irqbase is unsigned so the error handling
doesn't work.  I have changed it to be a regular int.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 53e7cac3
...@@ -79,7 +79,7 @@ struct mvebu_gpio_chip { ...@@ -79,7 +79,7 @@ struct mvebu_gpio_chip {
spinlock_t lock; spinlock_t lock;
void __iomem *membase; void __iomem *membase;
void __iomem *percpu_membase; void __iomem *percpu_membase;
unsigned int irqbase; int irqbase;
struct irq_domain *domain; struct irq_domain *domain;
int soc_variant; int soc_variant;
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment