Commit d59c6d9c authored by Gilad Ben-Yossef's avatar Gilad Ben-Yossef Committed by Greg Kroah-Hartman

staging: ccree: replace msleep with a completion

When the driver would try to queue commands to the HW FIFO but ran out of
slots it would use msleep as a delay until the FIFO would clear. This is
messy and not accurate.

Replace the msleep with a proper completion on the event of command
completion which should indicate at least one slot is free.
Signed-off-by: default avatarGilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5a83a393
...@@ -251,6 +251,8 @@ static int init_cc_resources(struct platform_device *plat_dev) ...@@ -251,6 +251,8 @@ static int init_cc_resources(struct platform_device *plat_dev)
} }
dev_dbg(dev, "Registered to IRQ: %d\n", new_drvdata->irq); dev_dbg(dev, "Registered to IRQ: %d\n", new_drvdata->irq);
init_completion(&new_drvdata->hw_queue_avail);
if (!plat_dev->dev.dma_mask) if (!plat_dev->dev.dma_mask)
plat_dev->dev.dma_mask = &plat_dev->dev.coherent_dma_mask; plat_dev->dev.dma_mask = &plat_dev->dev.coherent_dma_mask;
......
...@@ -125,6 +125,7 @@ struct ssi_drvdata { ...@@ -125,6 +125,7 @@ struct ssi_drvdata {
int irq; int irq;
u32 irq_mask; u32 irq_mask;
u32 fw_ver; u32 fw_ver;
struct completion hw_queue_avail; /* wait for HW queue availability */
struct platform_device *plat_dev; struct platform_device *plat_dev;
ssi_sram_addr_t mlli_sram_addr; ssi_sram_addr_t mlli_sram_addr;
void *buff_mgr_handle; void *buff_mgr_handle;
......
...@@ -312,8 +312,9 @@ int send_request( ...@@ -312,8 +312,9 @@ int send_request(
return rc; return rc;
} }
/* HW queue is full - short sleep */ /* HW queue is full - wait for it to clear up */
msleep(1); wait_for_completion_interruptible(&drvdata->hw_queue_avail);
reinit_completion(&drvdata->hw_queue_avail);
} while (1); } while (1);
/* Additional completion descriptor is needed incase caller did not /* Additional completion descriptor is needed incase caller did not
...@@ -452,6 +453,8 @@ void complete_request(struct ssi_drvdata *drvdata) ...@@ -452,6 +453,8 @@ void complete_request(struct ssi_drvdata *drvdata)
{ {
struct ssi_request_mgr_handle *request_mgr_handle = struct ssi_request_mgr_handle *request_mgr_handle =
drvdata->request_mgr_handle; drvdata->request_mgr_handle;
complete(&drvdata->hw_queue_avail);
#ifdef COMP_IN_WQ #ifdef COMP_IN_WQ
queue_delayed_work(request_mgr_handle->workq, queue_delayed_work(request_mgr_handle->workq,
&request_mgr_handle->compwork, 0); &request_mgr_handle->compwork, 0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment