Commit d5c4d84c authored by Lu Wei's avatar Lu Wei Committed by Greg Kroah-Hartman

platform/x86: intel-hid: Fix return value check in check_acpi_dev()

[ Upstream commit 71fbe886 ]

In the function check_acpi_dev(), if it fails to create
platform device, the return value is ERR_PTR() or NULL.
Thus it must use IS_ERR_OR_NULL() to check return value.

Fixes: ecc83e52 ("intel-hid: new hid event driver for hotkeys")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarLu Wei <luwei32@huawei.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent c0603524
...@@ -564,7 +564,7 @@ check_acpi_dev(acpi_handle handle, u32 lvl, void *context, void **rv) ...@@ -564,7 +564,7 @@ check_acpi_dev(acpi_handle handle, u32 lvl, void *context, void **rv)
return AE_OK; return AE_OK;
if (acpi_match_device_ids(dev, ids) == 0) if (acpi_match_device_ids(dev, ids) == 0)
if (acpi_create_platform_device(dev, NULL)) if (!IS_ERR_OR_NULL(acpi_create_platform_device(dev, NULL)))
dev_info(&dev->dev, dev_info(&dev->dev,
"intel-hid: created platform device\n"); "intel-hid: created platform device\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment