bcachefs: Fix deref of error pointer

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

bcachefs: Fix deref of error pointer
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
d65a8551 · Kent Overstreet · Kent Overstreet · 58677a1d · d65a8551
Commit d65a8551 authored Oct 04, 2019 by Kent Overstreet Committed by Kent Overstreet Oct 22, 2023
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

fs/bcachefs/str_hash.h fs/bcachefs/str_hash.h +3 -2

No files found.
--- a/fs/bcachefs/str_hash.h
+++ b/fs/bcachefs/str_hash.h
@@ -251,8 +251,9 @@ int bch2_hash_set(struct btree_trans *trans,
 	if (!ret)
 		ret = -ENOSPC;
 out:
-	if (slot)
+	if (!IS_ERR_OR_NULL(slot))
 		bch2_trans_iter_put(trans, slot);
+	if (!IS_ERR_OR_NULL(iter))
 		bch2_trans_iter_put(trans, iter);
 	return ret;