Commit d712eaf2 authored by Markus Elfring's avatar Markus Elfring Committed by Takashi Iwai

ALSA: core: Deletion of unnecessary checks before two function calls

The functions snd_seq_oss_timer_delete() and vunmap() perform also input
parameter validation. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent eaa8e5ef
...@@ -403,14 +403,11 @@ free_devinfo(void *private) ...@@ -403,14 +403,11 @@ free_devinfo(void *private)
{ {
struct seq_oss_devinfo *dp = (struct seq_oss_devinfo *)private; struct seq_oss_devinfo *dp = (struct seq_oss_devinfo *)private;
if (dp->timer) snd_seq_oss_timer_delete(dp->timer);
snd_seq_oss_timer_delete(dp->timer);
if (dp->writeq) snd_seq_oss_writeq_delete(dp->writeq);
snd_seq_oss_writeq_delete(dp->writeq);
if (dp->readq) snd_seq_oss_readq_delete(dp->readq);
snd_seq_oss_readq_delete(dp->readq);
kfree(dp); kfree(dp);
} }
......
...@@ -39,8 +39,7 @@ int snd_free_sgbuf_pages(struct snd_dma_buffer *dmab) ...@@ -39,8 +39,7 @@ int snd_free_sgbuf_pages(struct snd_dma_buffer *dmab)
if (! sgbuf) if (! sgbuf)
return -EINVAL; return -EINVAL;
if (dmab->area) vunmap(dmab->area);
vunmap(dmab->area);
dmab->area = NULL; dmab->area = NULL;
tmpb.dev.type = SNDRV_DMA_TYPE_DEV; tmpb.dev.type = SNDRV_DMA_TYPE_DEV;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment