Commit d717a3ab authored by Yuan Can's avatar Yuan Can Committed by Greg Kroah-Hartman

eeprom: idt_89hpesx: Fix error handling in idt_init()

A problem about idt_89hpesx create debugfs failed is triggered with the
following log given:

 [ 4973.269647] debugfs: Directory 'idt_csr' with parent '/' already present!

The reason is that idt_init() returns i2c_add_driver() directly without
checking its return value, if i2c_add_driver() failed, it returns without
destroy the newly created debugfs, resulting the debugfs of idt_csr can
never be created later.

 idt_init()
   debugfs_create_dir() # create debugfs directory
   i2c_add_driver()
     driver_register()
       bus_add_driver()
         priv = kzalloc(...) # OOM happened
   # return without destroy debugfs directory

Fix by removing debugfs when i2c_add_driver() returns error.

Fixes: cfad6425 ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
Signed-off-by: default avatarYuan Can <yuancan@huawei.com>
Acked-by: default avatarSerge Semin <fancer.lancer@gmail.com>
Link: https://lore.kernel.org/r/20221110020030.47711-1-yuancan@huawei.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0eb468b6
...@@ -1566,12 +1566,20 @@ static struct i2c_driver idt_driver = { ...@@ -1566,12 +1566,20 @@ static struct i2c_driver idt_driver = {
*/ */
static int __init idt_init(void) static int __init idt_init(void)
{ {
int ret;
/* Create Debugfs directory first */ /* Create Debugfs directory first */
if (debugfs_initialized()) if (debugfs_initialized())
csr_dbgdir = debugfs_create_dir("idt_csr", NULL); csr_dbgdir = debugfs_create_dir("idt_csr", NULL);
/* Add new i2c-device driver */ /* Add new i2c-device driver */
return i2c_add_driver(&idt_driver); ret = i2c_add_driver(&idt_driver);
if (ret) {
debugfs_remove_recursive(csr_dbgdir);
return ret;
}
return 0;
} }
module_init(idt_init); module_init(idt_init);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment