Commit d73c1c99 authored by Inki Dae's avatar Inki Dae

drm/exynos: use __free_page() to deallocate memory

this patch uses __free_page() to deallocate the pages allocated
by alloc_page() and the pages doesn't need set_parge_dirty()
and mark_page_accessed() because they aren't from page cache so
removes them.

this patch has a pair with previous patch below,
	http://www.spinics.net/lists/dri-devel/msg24382.html

Changelog v2:
remove unnecessary arguments.

Changelog v3:
fix npages type.
- npages can have negative value.
Signed-off-by: default avatarInki Dae <inki.dae@samsung.com>
Signed-off-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
parent 3c52b880
...@@ -126,23 +126,14 @@ struct page **exynos_gem_get_pages(struct drm_gem_object *obj, ...@@ -126,23 +126,14 @@ struct page **exynos_gem_get_pages(struct drm_gem_object *obj,
} }
static void exynos_gem_put_pages(struct drm_gem_object *obj, static void exynos_gem_put_pages(struct drm_gem_object *obj,
struct page **pages, struct page **pages)
bool dirty, bool accessed)
{ {
int i, npages; int npages;
npages = obj->size >> PAGE_SHIFT; npages = obj->size >> PAGE_SHIFT;
for (i = 0; i < npages; i++) { while (--npages >= 0)
if (dirty) __free_page(pages[npages]);
set_page_dirty(pages[i]);
if (accessed)
mark_page_accessed(pages[i]);
/* Undo the reference we took when populating the table */
page_cache_release(pages[i]);
}
drm_free_large(pages); drm_free_large(pages);
} }
...@@ -222,7 +213,7 @@ static int exynos_drm_gem_get_pages(struct drm_gem_object *obj) ...@@ -222,7 +213,7 @@ static int exynos_drm_gem_get_pages(struct drm_gem_object *obj)
kfree(buf->sgt); kfree(buf->sgt);
buf->sgt = NULL; buf->sgt = NULL;
err: err:
exynos_gem_put_pages(obj, pages, true, false); exynos_gem_put_pages(obj, pages);
return ret; return ret;
} }
...@@ -240,7 +231,7 @@ static void exynos_drm_gem_put_pages(struct drm_gem_object *obj) ...@@ -240,7 +231,7 @@ static void exynos_drm_gem_put_pages(struct drm_gem_object *obj)
kfree(buf->sgt); kfree(buf->sgt);
buf->sgt = NULL; buf->sgt = NULL;
exynos_gem_put_pages(obj, buf->pages, true, false); exynos_gem_put_pages(obj, buf->pages);
buf->pages = NULL; buf->pages = NULL;
/* add some codes for UNCACHED type here. TODO */ /* add some codes for UNCACHED type here. TODO */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment