Commit d79749f7 authored by Miaoqing Pan's avatar Miaoqing Pan Committed by Kalle Valo

ath10k: fix latency issue for QCA988x

(kvalo: cherry picked from commit 1340cc63 in
wireless-drivers-next to wireless-drivers as this a frequently reported
regression)

Bad latency is found on QCA988x, the issue was introduced by
commit 4504f0e5 ("ath10k: sdio: workaround firmware UART
pin configuration bug"). If uart_pin_workaround is false, this
change will set uart pin even if uart_print is false.

Tested HW: QCA9880
Tested FW: 10.2.4-1.0-00037

Fixes: 4504f0e5 ("ath10k: sdio: workaround firmware UART pin configuration bug")
Signed-off-by: default avatarMiaoqing Pan <miaoqing@codeaurora.org>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 3aed8837
...@@ -2118,12 +2118,15 @@ static int ath10k_init_uart(struct ath10k *ar) ...@@ -2118,12 +2118,15 @@ static int ath10k_init_uart(struct ath10k *ar)
return ret; return ret;
} }
if (!uart_print && ar->hw_params.uart_pin_workaround) { if (!uart_print) {
ret = ath10k_bmi_write32(ar, hi_dbg_uart_txpin, if (ar->hw_params.uart_pin_workaround) {
ar->hw_params.uart_pin); ret = ath10k_bmi_write32(ar, hi_dbg_uart_txpin,
if (ret) { ar->hw_params.uart_pin);
ath10k_warn(ar, "failed to set UART TX pin: %d", ret); if (ret) {
return ret; ath10k_warn(ar, "failed to set UART TX pin: %d",
ret);
return ret;
}
} }
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment