[PATCH] Fix ext3 add_nondir d_instantiate()

It should be unconditional.

[PATCH] Fix ext3 add_nondir d_instantiate()
It should be unconditional.
d7fb2760 · Andrew Morton · Linus Torvalds · e0ae6ae6 · d7fb2760
Commit d7fb2760 authored Apr 13, 2004 by Andrew Morton Committed by Linus Torvalds Apr 13, 2004
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 5 deletions

fs/ext3/namei.c fs/ext3/namei.c +3 -5

No files found.
--- a/fs/ext3/namei.c
+++ b/fs/ext3/namei.c
@@ -1606,11 +1606,9 @@ static int ext3_add_nondir(handle_t *handle,
 {
 	int err = ext3_add_entry(handle, dentry, inode);
 	if (!err) {
-		err = ext3_mark_inode_dirty(handle, inode);
+		ext3_mark_inode_dirty(handle, inode);
-		if (!err) {
+		d_instantiate(dentry, inode);
-			d_instantiate(dentry, inode);
+		return 0;
-			return 0;
-		}
 	}
 	ext3_dec_count(handle, inode);
 	iput(inode);