Skip to content

L
linux
Commit d83f4131 authored by Pierre-Yves MORDRET's avatar Pierre-Yves MORDRET Committed by Vinod Koul
Browse files
Options

dmaengine: stm32_mdma: activate pack/unpack feature 

If source and destination bus width differs pack/unpack MDMA
feature has to be activated for alignment.
This pack/unpack feature implies to have both source/destination address
and buffer length aligned on bus width.

Fixes: a4ffb13c ("dmaengine: Add STM32 MDMA driver")
Signed-off-by: default avatarPierre-Yves MORDRET <pierre-yves.mordret@st.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent f2fd4d9f
Hide whitespace changes
Inline Side-by-side
Showing with 50 additions and 34 deletions
drivers/dma/stm32-mdma.c
View file @ d83f4131
...@@ -387,14 +387,20 @@ static int stm32_mdma_get_width(struct stm32_mdma_chan *chan, ...@@ -387,14 +387,20 @@ static int stm32_mdma_get_width(struct stm32_mdma_chan *chan,
} }
} }
static enum dma_slave_buswidth stm32_mdma_get_max_width(u32 buf_len, u32 tlen) static enum dma_slave_buswidth stm32_mdma_get_max_width(dma_addr_t addr,
u32 buf_len, u32 tlen)
{ {
enum dma_slave_buswidth max_width = DMA_SLAVE_BUSWIDTH_8_BYTES; enum dma_slave_buswidth max_width = DMA_SLAVE_BUSWIDTH_8_BYTES;
for (max_width = DMA_SLAVE_BUSWIDTH_8_BYTES; for (max_width = DMA_SLAVE_BUSWIDTH_8_BYTES;
max_width > DMA_SLAVE_BUSWIDTH_1_BYTE; max_width > DMA_SLAVE_BUSWIDTH_1_BYTE;
max_width >>= 1) { max_width >>= 1) {
if (((buf_len % max_width) == 0) && (tlen >= max_width)) /*
* Address and buffer length both have to be aligned on
* bus width
*/
if ((((buf_len | addr) & (max_width - 1)) == 0) &&
tlen >= max_width)
break; break;
} }
...@@ -486,7 +492,8 @@ static void stm32_mdma_set_bus(struct stm32_mdma_device *dmadev, u32 *ctbr, ...@@ -486,7 +492,8 @@ static void stm32_mdma_set_bus(struct stm32_mdma_device *dmadev, u32 *ctbr,
static int stm32_mdma_set_xfer_param(struct stm32_mdma_chan *chan, static int stm32_mdma_set_xfer_param(struct stm32_mdma_chan *chan,
enum dma_transfer_direction direction, enum dma_transfer_direction direction,
u32 *mdma_ccr, u32 *mdma_ctcr, u32 *mdma_ccr, u32 *mdma_ctcr,
u32 *mdma_ctbr, u32 buf_len) u32 *mdma_ctbr, dma_addr_t addr,
u32 buf_len)
{ {
struct stm32_mdma_device *dmadev = stm32_mdma_get_dev(chan); struct stm32_mdma_device *dmadev = stm32_mdma_get_dev(chan);
struct stm32_mdma_chan_config *chan_config = &chan->chan_config; struct stm32_mdma_chan_config *chan_config = &chan->chan_config;
...@@ -520,6 +527,9 @@ static int stm32_mdma_set_xfer_param(struct stm32_mdma_chan *chan, ...@@ -520,6 +527,9 @@ static int stm32_mdma_set_xfer_param(struct stm32_mdma_chan *chan,
ctcr &= ~STM32_MDMA_CTCR_LEN2_MSK; ctcr &= ~STM32_MDMA_CTCR_LEN2_MSK;
ctcr |= STM32_MDMA_CTCR_TLEN((tlen - 1)); ctcr |= STM32_MDMA_CTCR_TLEN((tlen - 1));
/* Disable Pack Enable */
ctcr &= ~STM32_MDMA_CTCR_PKE;
/* Check burst size constraints */ /* Check burst size constraints */
if (src_maxburst * src_addr_width > STM32_MDMA_MAX_BURST || if (src_maxburst * src_addr_width > STM32_MDMA_MAX_BURST ||
dst_maxburst * dst_addr_width > STM32_MDMA_MAX_BURST) { dst_maxburst * dst_addr_width > STM32_MDMA_MAX_BURST) {
...@@ -551,6 +561,8 @@ static int stm32_mdma_set_xfer_param(struct stm32_mdma_chan *chan, ...@@ -551,6 +561,8 @@ static int stm32_mdma_set_xfer_param(struct stm32_mdma_chan *chan,
switch (direction) { switch (direction) {
case DMA_MEM_TO_DEV: case DMA_MEM_TO_DEV:
dst_addr = chan->dma_config.dst_addr;
/* Set device data size */ /* Set device data size */
dst_bus_width = stm32_mdma_get_width(chan, dst_addr_width); dst_bus_width = stm32_mdma_get_width(chan, dst_addr_width);
if (dst_bus_width < 0) if (dst_bus_width < 0)
...@@ -567,7 +579,7 @@ static int stm32_mdma_set_xfer_param(struct stm32_mdma_chan *chan, ...@@ -567,7 +579,7 @@ static int stm32_mdma_set_xfer_param(struct stm32_mdma_chan *chan,
ctcr |= STM32_MDMA_CTCR_DBURST((ilog2(dst_best_burst))); ctcr |= STM32_MDMA_CTCR_DBURST((ilog2(dst_best_burst)));
/* Set memory data size */ /* Set memory data size */
src_addr_width = stm32_mdma_get_max_width(buf_len, tlen); src_addr_width = stm32_mdma_get_max_width(addr, buf_len, tlen);
chan->mem_width = src_addr_width; chan->mem_width = src_addr_width;
src_bus_width = stm32_mdma_get_width(chan, src_addr_width); src_bus_width = stm32_mdma_get_width(chan, src_addr_width);
if (src_bus_width < 0) if (src_bus_width < 0)
...@@ -587,15 +599,19 @@ static int stm32_mdma_set_xfer_param(struct stm32_mdma_chan *chan, ...@@ -587,15 +599,19 @@ static int stm32_mdma_set_xfer_param(struct stm32_mdma_chan *chan,
ctcr |= STM32_MDMA_CTCR_SBURST((ilog2(src_best_burst))); ctcr |= STM32_MDMA_CTCR_SBURST((ilog2(src_best_burst)));
/* Select bus */ /* Select bus */
dst_addr = chan->dma_config.dst_addr;
stm32_mdma_set_bus(dmadev, &ctbr, STM32_MDMA_CTBR_DBUS, stm32_mdma_set_bus(dmadev, &ctbr, STM32_MDMA_CTBR_DBUS,
dst_addr); dst_addr);
if (dst_bus_width != src_bus_width)
ctcr |= STM32_MDMA_CTCR_PKE;
/* Set destination address */ /* Set destination address */
stm32_mdma_write(dmadev, STM32_MDMA_CDAR(chan->id), dst_addr); stm32_mdma_write(dmadev, STM32_MDMA_CDAR(chan->id), dst_addr);
break; break;
case DMA_DEV_TO_MEM: case DMA_DEV_TO_MEM:
src_addr = chan->dma_config.src_addr;
/* Set device data size */ /* Set device data size */
src_bus_width = stm32_mdma_get_width(chan, src_addr_width); src_bus_width = stm32_mdma_get_width(chan, src_addr_width);
if (src_bus_width < 0) if (src_bus_width < 0)
...@@ -611,7 +627,7 @@ static int stm32_mdma_set_xfer_param(struct stm32_mdma_chan *chan, ...@@ -611,7 +627,7 @@ static int stm32_mdma_set_xfer_param(struct stm32_mdma_chan *chan,
ctcr |= STM32_MDMA_CTCR_SBURST((ilog2(src_best_burst))); ctcr |= STM32_MDMA_CTCR_SBURST((ilog2(src_best_burst)));
/* Set memory data size */ /* Set memory data size */
dst_addr_width = stm32_mdma_get_max_width(buf_len, tlen); dst_addr_width = stm32_mdma_get_max_width(addr, buf_len, tlen);
chan->mem_width = dst_addr_width; chan->mem_width = dst_addr_width;
dst_bus_width = stm32_mdma_get_width(chan, dst_addr_width); dst_bus_width = stm32_mdma_get_width(chan, dst_addr_width);
if (dst_bus_width < 0) if (dst_bus_width < 0)
...@@ -630,10 +646,12 @@ static int stm32_mdma_set_xfer_param(struct stm32_mdma_chan *chan, ...@@ -630,10 +646,12 @@ static int stm32_mdma_set_xfer_param(struct stm32_mdma_chan *chan,
ctcr |= STM32_MDMA_CTCR_DBURST((ilog2(dst_best_burst))); ctcr |= STM32_MDMA_CTCR_DBURST((ilog2(dst_best_burst)));
/* Select bus */ /* Select bus */
src_addr = chan->dma_config.src_addr;
stm32_mdma_set_bus(dmadev, &ctbr, STM32_MDMA_CTBR_SBUS, stm32_mdma_set_bus(dmadev, &ctbr, STM32_MDMA_CTBR_SBUS,
src_addr); src_addr);
if (dst_bus_width != src_bus_width)
ctcr |= STM32_MDMA_CTCR_PKE;
/* Set source address */ /* Set source address */
stm32_mdma_write(dmadev, STM32_MDMA_CSAR(chan->id), src_addr); stm32_mdma_write(dmadev, STM32_MDMA_CSAR(chan->id), src_addr);
break; break;
...@@ -719,23 +737,27 @@ static int stm32_mdma_setup_xfer(struct stm32_mdma_chan *chan, ...@@ -719,23 +737,27 @@ static int stm32_mdma_setup_xfer(struct stm32_mdma_chan *chan,
return -EINVAL; return -EINVAL;
} }
ret = stm32_mdma_set_xfer_param(chan, direction, &ccr, &ctcr,
&ctbr, sg_dma_len(sg));
if (ret < 0)
return ret;
if (direction == DMA_MEM_TO_DEV) { if (direction == DMA_MEM_TO_DEV) {
src_addr = sg_dma_address(sg); src_addr = sg_dma_address(sg);
dst_addr = dma_config->dst_addr; dst_addr = dma_config->dst_addr;
ret = stm32_mdma_set_xfer_param(chan, direction, &ccr,
&ctcr, &ctbr, src_addr,
sg_dma_len(sg));
stm32_mdma_set_bus(dmadev, &ctbr, STM32_MDMA_CTBR_SBUS, stm32_mdma_set_bus(dmadev, &ctbr, STM32_MDMA_CTBR_SBUS,
src_addr); src_addr);
} else { } else {
src_addr = dma_config->src_addr; src_addr = dma_config->src_addr;
dst_addr = sg_dma_address(sg); dst_addr = sg_dma_address(sg);
ret = stm32_mdma_set_xfer_param(chan, direction, &ccr,
&ctcr, &ctbr, dst_addr,
sg_dma_len(sg));
stm32_mdma_set_bus(dmadev, &ctbr, STM32_MDMA_CTBR_DBUS, stm32_mdma_set_bus(dmadev, &ctbr, STM32_MDMA_CTBR_DBUS,
dst_addr); dst_addr);
} }
if (ret < 0)
return ret;
stm32_mdma_setup_hwdesc(chan, desc, direction, i, src_addr, stm32_mdma_setup_hwdesc(chan, desc, direction, i, src_addr,
dst_addr, sg_dma_len(sg), ctcr, ctbr, dst_addr, sg_dma_len(sg), ctcr, ctbr,
i == sg_len - 1, i == 0, false); i == sg_len - 1, i == 0, false);
...@@ -830,27 +852,29 @@ stm32_mdma_prep_dma_cyclic(struct dma_chan *c, dma_addr_t buf_addr, ...@@ -830,27 +852,29 @@ stm32_mdma_prep_dma_cyclic(struct dma_chan *c, dma_addr_t buf_addr,
if (!desc) if (!desc)
return NULL; return NULL;
ret = stm32_mdma_set_xfer_param(chan, direction, &ccr, &ctcr, &ctbr,
period_len);
if (ret < 0)
goto xfer_setup_err;
/* Enable interrupts */
ccr &= ~STM32_MDMA_CCR_IRQ_MASK;
ccr |= STM32_MDMA_CCR_TEIE | STM32_MDMA_CCR_CTCIE | STM32_MDMA_CCR_BTIE;
desc->ccr = ccr;
/* Select bus */ /* Select bus */
if (direction == DMA_MEM_TO_DEV) { if (direction == DMA_MEM_TO_DEV) {
src_addr = buf_addr; src_addr = buf_addr;
ret = stm32_mdma_set_xfer_param(chan, direction, &ccr, &ctcr,
&ctbr, src_addr, period_len);
stm32_mdma_set_bus(dmadev, &ctbr, STM32_MDMA_CTBR_SBUS, stm32_mdma_set_bus(dmadev, &ctbr, STM32_MDMA_CTBR_SBUS,
src_addr); src_addr);
} else { } else {
dst_addr = buf_addr; dst_addr = buf_addr;
ret = stm32_mdma_set_xfer_param(chan, direction, &ccr, &ctcr,
&ctbr, dst_addr, period_len);
stm32_mdma_set_bus(dmadev, &ctbr, STM32_MDMA_CTBR_DBUS, stm32_mdma_set_bus(dmadev, &ctbr, STM32_MDMA_CTBR_DBUS,
dst_addr); dst_addr);
} }
if (ret < 0)
goto xfer_setup_err;
/* Enable interrupts */
ccr &= ~STM32_MDMA_CCR_IRQ_MASK;
ccr |= STM32_MDMA_CCR_TEIE | STM32_MDMA_CCR_CTCIE | STM32_MDMA_CCR_BTIE;
desc->ccr = ccr;
/* Configure hwdesc list */ /* Configure hwdesc list */
for (i = 0; i < count; i++) { for (i = 0; i < count; i++) {
if (direction == DMA_MEM_TO_DEV) { if (direction == DMA_MEM_TO_DEV) {
...@@ -956,9 +980,7 @@ stm32_mdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, ...@@ -956,9 +980,7 @@ stm32_mdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
ctcr |= STM32_MDMA_CTCR_TLEN((tlen - 1)); ctcr |= STM32_MDMA_CTCR_TLEN((tlen - 1));
/* Set source best burst size */ /* Set source best burst size */
max_width = stm32_mdma_get_max_width(len, tlen); max_width = stm32_mdma_get_max_width(src, len, tlen);
if (src % max_width)
max_width = DMA_SLAVE_BUSWIDTH_1_BYTE;
src_bus_width = stm32_mdma_get_width(chan, max_width); src_bus_width = stm32_mdma_get_width(chan, max_width);
max_burst = tlen / max_width; max_burst = tlen / max_width;
...@@ -971,9 +993,7 @@ stm32_mdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, ...@@ -971,9 +993,7 @@ stm32_mdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
STM32_MDMA_CTCR_SINCOS(src_bus_width); STM32_MDMA_CTCR_SINCOS(src_bus_width);
/* Set destination best burst size */ /* Set destination best burst size */
max_width = stm32_mdma_get_max_width(len, tlen); max_width = stm32_mdma_get_max_width(dest, len, tlen);
if (dest % max_width)
max_width = DMA_SLAVE_BUSWIDTH_1_BYTE;
dst_bus_width = stm32_mdma_get_width(chan, max_width); dst_bus_width = stm32_mdma_get_width(chan, max_width);
max_burst = tlen / max_width; max_burst = tlen / max_width;
...@@ -1014,9 +1034,7 @@ stm32_mdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, ...@@ -1014,9 +1034,7 @@ stm32_mdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
STM32_MDMA_MAX_BLOCK_LEN); STM32_MDMA_MAX_BLOCK_LEN);
/* Set source best burst size */ /* Set source best burst size */
max_width = stm32_mdma_get_max_width(len, tlen); max_width = stm32_mdma_get_max_width(src, len, tlen);
if (src % max_width)
max_width = DMA_SLAVE_BUSWIDTH_1_BYTE;
src_bus_width = stm32_mdma_get_width(chan, max_width); src_bus_width = stm32_mdma_get_width(chan, max_width);
max_burst = tlen / max_width; max_burst = tlen / max_width;
...@@ -1030,9 +1048,7 @@ stm32_mdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, ...@@ -1030,9 +1048,7 @@ stm32_mdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
STM32_MDMA_CTCR_SINCOS(src_bus_width); STM32_MDMA_CTCR_SINCOS(src_bus_width);
/* Set destination best burst size */ /* Set destination best burst size */
max_width = stm32_mdma_get_max_width(len, tlen); max_width = stm32_mdma_get_max_width(dest, len, tlen);
if (dest % max_width)
max_width = DMA_SLAVE_BUSWIDTH_1_BYTE;
dst_bus_width = stm32_mdma_get_width(chan, max_width); dst_bus_width = stm32_mdma_get_width(chan, max_width);
max_burst = tlen / max_width; max_burst = tlen / max_width;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7