Commit d8986600 authored by Hugues Fruchet's avatar Hugues Fruchet Committed by Mauro Carvalho Chehab

media: stm32-dcmi: fix error messages

Revisit and add some error messages.
Signed-off-by: default avatarHugues Fruchet <hugues.fruchet@st.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 0646d347
...@@ -1611,7 +1611,7 @@ static int dcmi_graph_init(struct stm32_dcmi *dcmi) ...@@ -1611,7 +1611,7 @@ static int dcmi_graph_init(struct stm32_dcmi *dcmi)
/* Parse the graph to extract a list of subdevice DT nodes. */ /* Parse the graph to extract a list of subdevice DT nodes. */
ret = dcmi_graph_parse(dcmi, dcmi->dev->of_node); ret = dcmi_graph_parse(dcmi, dcmi->dev->of_node);
if (ret < 0) { if (ret < 0) {
dev_err(dcmi->dev, "Graph parsing failed\n"); dev_err(dcmi->dev, "Failed to parse graph\n");
return ret; return ret;
} }
...@@ -1620,6 +1620,7 @@ static int dcmi_graph_init(struct stm32_dcmi *dcmi) ...@@ -1620,6 +1620,7 @@ static int dcmi_graph_init(struct stm32_dcmi *dcmi)
ret = v4l2_async_notifier_add_subdev(&dcmi->notifier, ret = v4l2_async_notifier_add_subdev(&dcmi->notifier,
&dcmi->entity.asd); &dcmi->entity.asd);
if (ret) { if (ret) {
dev_err(dcmi->dev, "Failed to add subdev notifier\n");
of_node_put(dcmi->entity.node); of_node_put(dcmi->entity.node);
return ret; return ret;
} }
...@@ -1628,7 +1629,7 @@ static int dcmi_graph_init(struct stm32_dcmi *dcmi) ...@@ -1628,7 +1629,7 @@ static int dcmi_graph_init(struct stm32_dcmi *dcmi)
ret = v4l2_async_notifier_register(&dcmi->v4l2_dev, &dcmi->notifier); ret = v4l2_async_notifier_register(&dcmi->v4l2_dev, &dcmi->notifier);
if (ret < 0) { if (ret < 0) {
dev_err(dcmi->dev, "Notifier registration failed\n"); dev_err(dcmi->dev, "Failed to register notifier\n");
v4l2_async_notifier_cleanup(&dcmi->notifier); v4l2_async_notifier_cleanup(&dcmi->notifier);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment