Commit d93af50e authored by Jiri Kosina's avatar Jiri Kosina

Merge branch 'for-4.20/core' into for-linus

Fixes and new features for driver core. Highlights:

- maximum global item tag report size gets increased to 256
- improved INPUT_PROP reporting for Digitizer devices
parents 037ad063 8473a93d
...@@ -406,7 +406,7 @@ static int hid_parser_global(struct hid_parser *parser, struct hid_item *item) ...@@ -406,7 +406,7 @@ static int hid_parser_global(struct hid_parser *parser, struct hid_item *item)
case HID_GLOBAL_ITEM_TAG_REPORT_SIZE: case HID_GLOBAL_ITEM_TAG_REPORT_SIZE:
parser->global.report_size = item_udata(item); parser->global.report_size = item_udata(item);
if (parser->global.report_size > 128) { if (parser->global.report_size > 256) {
hid_err(parser->device, "invalid report_size %d\n", hid_err(parser->device, "invalid report_size %d\n",
parser->global.report_size); parser->global.report_size);
return -1; return -1;
......
...@@ -758,6 +758,11 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel ...@@ -758,6 +758,11 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
break; break;
case HID_UP_DIGITIZER: case HID_UP_DIGITIZER:
if ((field->application & 0xff) == 0x01) /* Digitizer */
__set_bit(INPUT_PROP_POINTER, input->propbit);
else if ((field->application & 0xff) == 0x02) /* Pen */
__set_bit(INPUT_PROP_DIRECT, input->propbit);
switch (usage->hid & 0xff) { switch (usage->hid & 0xff) {
case 0x00: /* Undefined */ case 0x00: /* Undefined */
goto ignore; goto ignore;
...@@ -1516,6 +1521,7 @@ static struct hid_input *hidinput_allocate(struct hid_device *hid, ...@@ -1516,6 +1521,7 @@ static struct hid_input *hidinput_allocate(struct hid_device *hid,
struct hid_input *hidinput = kzalloc(sizeof(*hidinput), GFP_KERNEL); struct hid_input *hidinput = kzalloc(sizeof(*hidinput), GFP_KERNEL);
struct input_dev *input_dev = input_allocate_device(); struct input_dev *input_dev = input_allocate_device();
const char *suffix = NULL; const char *suffix = NULL;
size_t suffix_len, name_len;
if (!hidinput || !input_dev) if (!hidinput || !input_dev)
goto fail; goto fail;
...@@ -1559,10 +1565,15 @@ static struct hid_input *hidinput_allocate(struct hid_device *hid, ...@@ -1559,10 +1565,15 @@ static struct hid_input *hidinput_allocate(struct hid_device *hid,
} }
if (suffix) { if (suffix) {
hidinput->name = kasprintf(GFP_KERNEL, "%s %s", name_len = strlen(hid->name);
hid->name, suffix); suffix_len = strlen(suffix);
if (!hidinput->name) if ((name_len < suffix_len) ||
goto fail; strcmp(hid->name + name_len - suffix_len, suffix)) {
hidinput->name = kasprintf(GFP_KERNEL, "%s %s",
hid->name, suffix);
if (!hidinput->name)
goto fail;
}
} }
input_set_drvdata(input_dev, hid); input_set_drvdata(input_dev, hid);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment