Commit d95dc9e3 authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Sebastian Reichel

HSI: nokia-modem: fix error handling of irq_of_parse_and_map

Return value of irq_of_parse_and_map() is unsigned int, with 0
indicating failure, so testing for negative result never works.
Signed-off-by: default avatarDmitry Torokhov <dtor@chromium.org>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
parent cdb83947
...@@ -164,9 +164,9 @@ static int nokia_modem_probe(struct device *dev) ...@@ -164,9 +164,9 @@ static int nokia_modem_probe(struct device *dev)
dev_set_drvdata(dev, modem); dev_set_drvdata(dev, modem);
irq = irq_of_parse_and_map(np, 0); irq = irq_of_parse_and_map(np, 0);
if (irq < 0) { if (!irq) {
dev_err(dev, "Invalid rst_ind interrupt (%d)\n", irq); dev_err(dev, "Invalid rst_ind interrupt (%d)\n", irq);
return irq; return -EINVAL;
} }
modem->nokia_modem_rst_ind_irq = irq; modem->nokia_modem_rst_ind_irq = irq;
pflags = irq_get_trigger_type(irq); pflags = irq_get_trigger_type(irq);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment