Commit d9e709d0 authored by Shreeya Patel's avatar Shreeya Patel Committed by Greg Kroah-Hartman

Staging: wilc1000: cfg80211: Use kmemdup instead of kmalloc and memcpy

Replace calls to kmalloc followed by a memcpy with a direct call to
kmemdup.

The Coccinelle semantic patch used to make this change is as follows:
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);
Signed-off-by: default avatarShreeya Patel <shreeya.patel23498@gmail.com>
Reviewed-by: default avatarStefano Brivio <sbrivio@redhat.com>
Link: https://lore.kernel.org/r/20200313112451.25610-1-shreeya.patel23498@gmail.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 76498b49
...@@ -1142,14 +1142,13 @@ static int mgmt_tx(struct wiphy *wiphy, ...@@ -1142,14 +1142,13 @@ static int mgmt_tx(struct wiphy *wiphy,
goto out; goto out;
} }
mgmt_tx->buff = kmalloc(len, GFP_KERNEL); mgmt_tx->buff = kmemdup(buf, len, GFP_KERNEL);
if (!mgmt_tx->buff) { if (!mgmt_tx->buff) {
ret = -ENOMEM; ret = -ENOMEM;
kfree(mgmt_tx); kfree(mgmt_tx);
goto out; goto out;
} }
memcpy(mgmt_tx->buff, buf, len);
mgmt_tx->size = len; mgmt_tx->size = len;
if (ieee80211_is_probe_resp(mgmt->frame_control)) { if (ieee80211_is_probe_resp(mgmt->frame_control)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment