Commit d9f5efad authored by Yoshihiro Shimoda's avatar Yoshihiro Shimoda Committed by Vinod Koul

dmaengine: usb-dmac: fix endless loop in usb_dmac_chan_terminate_all()

This patch fixes an issue that list_for_each_entry() in
usb_dmac_chan_terminate_all() is possible to cause endless loop because
this will move own desc to the desc_freed. So, this driver should use
list_for_each_entry_safe() instead of list_for_each_entry().
Signed-off-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 8005c49d
...@@ -448,7 +448,7 @@ usb_dmac_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl, ...@@ -448,7 +448,7 @@ usb_dmac_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,
static int usb_dmac_chan_terminate_all(struct dma_chan *chan) static int usb_dmac_chan_terminate_all(struct dma_chan *chan)
{ {
struct usb_dmac_chan *uchan = to_usb_dmac_chan(chan); struct usb_dmac_chan *uchan = to_usb_dmac_chan(chan);
struct usb_dmac_desc *desc; struct usb_dmac_desc *desc, *_desc;
unsigned long flags; unsigned long flags;
LIST_HEAD(head); LIST_HEAD(head);
LIST_HEAD(list); LIST_HEAD(list);
...@@ -459,7 +459,7 @@ static int usb_dmac_chan_terminate_all(struct dma_chan *chan) ...@@ -459,7 +459,7 @@ static int usb_dmac_chan_terminate_all(struct dma_chan *chan)
if (uchan->desc) if (uchan->desc)
uchan->desc = NULL; uchan->desc = NULL;
list_splice_init(&uchan->desc_got, &list); list_splice_init(&uchan->desc_got, &list);
list_for_each_entry(desc, &list, node) list_for_each_entry_safe(desc, _desc, &list, node)
list_move_tail(&desc->node, &uchan->desc_freed); list_move_tail(&desc->node, &uchan->desc_freed);
spin_unlock_irqrestore(&uchan->vc.lock, flags); spin_unlock_irqrestore(&uchan->vc.lock, flags);
vchan_dma_desc_free_list(&uchan->vc, &head); vchan_dma_desc_free_list(&uchan->vc, &head);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment