Commit da10a200 authored by Anton Vorontsov's avatar Anton Vorontsov Committed by Jeff Garzik

ahci_platform: Remove unneeded ahci_driver.probe assignment

The driver is using platform_driver_probe() during initialization,
so ahci_driver.probe hook is never used.

But it causes the following (harmless, luckily) section mismatch:

  WARNING: vmlinux.o(.data+0x2fb20): Section mismatch in reference
  from the variable ahci_driver to the function .init.text:ahci_probe()

This patch removes the ahci_driver.probe assignment, thus fixes
the warning.

p.s. Note that there's another patch[1] from Rene Bolldorf that
tried to solve the same issue by __refdata annotation. __refdata
says that this reference is actually OK, but in fact it is not OK,
because dereferencing .probe() will cause problems. So the proper
fix is to remove the assignment.

[1] http://kerneltrap.org/mailarchive/linux-kernel/2010/3/18/4549547Signed-off-by: default avatarAnton Vorontsov <avorontsov@mvista.com>
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent 08354809
...@@ -171,7 +171,6 @@ static int __devexit ahci_remove(struct platform_device *pdev) ...@@ -171,7 +171,6 @@ static int __devexit ahci_remove(struct platform_device *pdev)
} }
static struct platform_driver ahci_driver = { static struct platform_driver ahci_driver = {
.probe = ahci_probe,
.remove = __devexit_p(ahci_remove), .remove = __devexit_p(ahci_remove),
.driver = { .driver = {
.name = "ahci", .name = "ahci",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment