Commit da46ee19 authored by Yang Yingliang's avatar Yang Yingliang Committed by Mark Brown

regulator: core: fix module refcount leak in set_supply()

If create_regulator() fails in set_supply(), the module refcount
needs be put to keep refcount balanced.

Fixes: e2c09ae7 ("regulator: core: Increase refcount for regulator supply's module")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221201122706.4055992-2-yangyingliang@huawei.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 0591b14c
...@@ -1646,6 +1646,7 @@ static int set_supply(struct regulator_dev *rdev, ...@@ -1646,6 +1646,7 @@ static int set_supply(struct regulator_dev *rdev,
rdev->supply = create_regulator(supply_rdev, &rdev->dev, "SUPPLY"); rdev->supply = create_regulator(supply_rdev, &rdev->dev, "SUPPLY");
if (rdev->supply == NULL) { if (rdev->supply == NULL) {
module_put(supply_rdev->owner);
err = -ENOMEM; err = -ENOMEM;
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment