Commit daa49ff5 authored by Anton Vorontsov's avatar Anton Vorontsov Committed by Linus Torvalds

ds1wm: report bus reset error

The patch replaces dev_dbg() by dev_err(), so the user could actually see the
error, instead of wondering why w1 doesn't work.  The root cause of the bus
reset error isn't yet debugged though, but this sometimes happens on iPaq
H5555.

And while I'm at it, some cosmetic cleanups also made (few lines were using
spaces instead of tabs).
Signed-off-by: default avatarAnton Vorontsov <cbouatmailru@gmail.com>
Acked-by: default avatarEvgeniy Polyakov <johnpol@2ka.mipt.ru>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent fbc357df
...@@ -150,7 +150,7 @@ static int ds1wm_reset(struct ds1wm_data *ds1wm_data) ...@@ -150,7 +150,7 @@ static int ds1wm_reset(struct ds1wm_data *ds1wm_data)
timeleft = wait_for_completion_timeout(&reset_done, DS1WM_TIMEOUT); timeleft = wait_for_completion_timeout(&reset_done, DS1WM_TIMEOUT);
ds1wm_data->reset_complete = NULL; ds1wm_data->reset_complete = NULL;
if (!timeleft) { if (!timeleft) {
dev_dbg(&ds1wm_data->pdev->dev, "reset failed\n"); dev_err(&ds1wm_data->pdev->dev, "reset failed\n");
return 1; return 1;
} }
...@@ -335,7 +335,7 @@ static int ds1wm_probe(struct platform_device *pdev) ...@@ -335,7 +335,7 @@ static int ds1wm_probe(struct platform_device *pdev)
if (!pdev) if (!pdev)
return -ENODEV; return -ENODEV;
ds1wm_data = kzalloc(sizeof (*ds1wm_data), GFP_KERNEL); ds1wm_data = kzalloc(sizeof(*ds1wm_data), GFP_KERNEL);
if (!ds1wm_data) if (!ds1wm_data)
return -ENOMEM; return -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment