Commit db4e5376 authored by Pan Bian's avatar Pan Bian Committed by Jonathan Cameron

iio: light: fix improper return value

In function cm3232_reg_init(), it returns 0 even if the last call to
i2c_smbus_write_byte_data() returns a negative value (indicates error).
As a result, the return value may be inconsistent with the execution
status, and the caller of cm3232_reg_init() will not be able to detect
the error. This patch fixes the bug.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188641Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent 67351df7
...@@ -119,7 +119,7 @@ static int cm3232_reg_init(struct cm3232_chip *chip) ...@@ -119,7 +119,7 @@ static int cm3232_reg_init(struct cm3232_chip *chip)
if (ret < 0) if (ret < 0)
dev_err(&chip->client->dev, "Error writing reg_cmd\n"); dev_err(&chip->client->dev, "Error writing reg_cmd\n");
return 0; return ret;
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment