Commit db6207de authored by Shaohui Xie's avatar Shaohui Xie Committed by Luis Henriques

net: phy: fix PHY_RUNNING in phy_state_machine

commit 11e122cb upstream.

Currently, if phy state is PHY_RUNNING, we always register a CHANGE
when phy works in polling or interrupt ignored, this will make the
adjust_link being called even the phy link did Not changed.

checking the phy link to make sure the link did changed before we
register a CHANGE, if link did not changed, we do nothing.
Signed-off-by: default avatarShaohui Xie <Shaohui.Xie@freescale.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent ced18efa
...@@ -740,6 +740,7 @@ void phy_state_machine(struct work_struct *work) ...@@ -740,6 +740,7 @@ void phy_state_machine(struct work_struct *work)
container_of(dwork, struct phy_device, state_queue); container_of(dwork, struct phy_device, state_queue);
bool needs_aneg = false, do_suspend = false, do_resume = false; bool needs_aneg = false, do_suspend = false, do_resume = false;
int err = 0; int err = 0;
int old_link;
mutex_lock(&phydev->lock); mutex_lock(&phydev->lock);
...@@ -823,11 +824,18 @@ void phy_state_machine(struct work_struct *work) ...@@ -823,11 +824,18 @@ void phy_state_machine(struct work_struct *work)
phydev->adjust_link(phydev->attached_dev); phydev->adjust_link(phydev->attached_dev);
break; break;
case PHY_RUNNING: case PHY_RUNNING:
/* Only register a CHANGE if we are /* Only register a CHANGE if we are polling or ignoring
* polling or ignoring interrupts * interrupts and link changed since latest checking.
*/ */
if (!phy_interrupt_is_valid(phydev)) if (!phy_interrupt_is_valid(phydev)) {
old_link = phydev->link;
err = phy_read_status(phydev);
if (err)
break;
if (old_link != phydev->link)
phydev->state = PHY_CHANGELINK; phydev->state = PHY_CHANGELINK;
}
break; break;
case PHY_CHANGELINK: case PHY_CHANGELINK:
err = phy_read_status(phydev); err = phy_read_status(phydev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment