Commit db7437dd authored by liaoweixiong's avatar liaoweixiong Committed by Greg Kroah-Hartman

mtd: spinand: read returns badly if the last page has bitflips

commit b83408b5 upstream.

In case of the last page containing bitflips (ret > 0),
spinand_mtd_read() will return that number of bitflips for the last
page while it should instead return max_bitflips like it does when the
last page read returns with 0.
Signed-off-by: default avatarWeixiong Liao <liaoweixiong@allwinnertech.com>
Reviewed-by: default avatarBoris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: default avatarFrieder Schrempf <frieder.schrempf@kontron.de>
Cc: stable@vger.kernel.org
Fixes: 7529df46 ("mtd: nand: Add core infrastructure to support SPI NANDs")
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent df7cbb10
...@@ -572,12 +572,12 @@ static int spinand_mtd_read(struct mtd_info *mtd, loff_t from, ...@@ -572,12 +572,12 @@ static int spinand_mtd_read(struct mtd_info *mtd, loff_t from,
if (ret == -EBADMSG) { if (ret == -EBADMSG) {
ecc_failed = true; ecc_failed = true;
mtd->ecc_stats.failed++; mtd->ecc_stats.failed++;
ret = 0;
} else { } else {
mtd->ecc_stats.corrected += ret; mtd->ecc_stats.corrected += ret;
max_bitflips = max_t(unsigned int, max_bitflips, ret); max_bitflips = max_t(unsigned int, max_bitflips, ret);
} }
ret = 0;
ops->retlen += iter.req.datalen; ops->retlen += iter.req.datalen;
ops->oobretlen += iter.req.ooblen; ops->oobretlen += iter.req.ooblen;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment