Commit dc4246ef authored by Ping-Ke Shih's avatar Ping-Ke Shih Committed by Kalle Valo

rtw89: pci: correct return value handling of rtw89_write16_mdio_mask()

Fix wrong checking statement. Fortunately, this wrong code doesn't affect
existing chip.

Fixes: 740c431c ("rtw89: pci: add register definition to rtw89_pci_info to generalize pci code")
Signed-off-by: default avatarPing-Ke Shih <pkshih@realtek.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220413010804.8941-5-pkshih@realtek.com
parent 0a6f299b
...@@ -1522,7 +1522,7 @@ rtw89_write16_mdio_mask(struct rtw89_dev *rtwdev, u8 addr, u16 mask, u16 data, u ...@@ -1522,7 +1522,7 @@ rtw89_write16_mdio_mask(struct rtw89_dev *rtwdev, u8 addr, u16 mask, u16 data, u
u16 val; u16 val;
ret = rtw89_read16_mdio(rtwdev, addr, speed, &val); ret = rtw89_read16_mdio(rtwdev, addr, speed, &val);
if (!ret) if (ret)
return ret; return ret;
shift = __ffs(mask); shift = __ffs(mask);
...@@ -1530,7 +1530,7 @@ rtw89_write16_mdio_mask(struct rtw89_dev *rtwdev, u8 addr, u16 mask, u16 data, u ...@@ -1530,7 +1530,7 @@ rtw89_write16_mdio_mask(struct rtw89_dev *rtwdev, u8 addr, u16 mask, u16 data, u
val |= ((data << shift) & mask); val |= ((data << shift) & mask);
ret = rtw89_write16_mdio(rtwdev, addr, val, speed); ret = rtw89_write16_mdio(rtwdev, addr, val, speed);
if (!ret) if (ret)
return ret; return ret;
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment