Commit dcc0967d authored by Chris Lew's avatar Chris Lew Committed by Andy Gross

soc: qcom: smem: Read version from the smem header

The SMEM header structure includes the version information. Read the
version directly from the header instead of getting an item from the
global heap.
Signed-off-by: default avatarChris Lew <clew@codeaurora.org>
Acked-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: default avatarAndy Gross <andy.gross@linaro.org>
parent a216000f
...@@ -63,13 +63,12 @@ ...@@ -63,13 +63,12 @@
*/ */
/* /*
* Item 3 of the global heap contains an array of versions for the various * The version member of the smem header contains an array of versions for the
* software components in the SoC. We verify that the boot loader version is * various software components in the SoC. We verify that the boot loader
* what the expected version (SMEM_EXPECTED_VERSION) as a sanity check. * version is a valid version as a sanity check.
*/ */
#define SMEM_ITEM_VERSION 3 #define SMEM_MASTER_SBL_VERSION_INDEX 7
#define SMEM_MASTER_SBL_VERSION_INDEX 7 #define SMEM_EXPECTED_VERSION 11
#define SMEM_EXPECTED_VERSION 11
/* /*
* The first 8 items are only to be allocated by the boot loader while * The first 8 items are only to be allocated by the boot loader while
...@@ -604,19 +603,11 @@ EXPORT_SYMBOL(qcom_smem_get_free_space); ...@@ -604,19 +603,11 @@ EXPORT_SYMBOL(qcom_smem_get_free_space);
static int qcom_smem_get_sbl_version(struct qcom_smem *smem) static int qcom_smem_get_sbl_version(struct qcom_smem *smem)
{ {
struct smem_header *header;
__le32 *versions; __le32 *versions;
size_t size;
versions = qcom_smem_get_global(smem, SMEM_ITEM_VERSION, &size);
if (IS_ERR(versions)) {
dev_err(smem->dev, "Unable to read the version item\n");
return -ENOENT;
}
if (size < sizeof(unsigned) * SMEM_MASTER_SBL_VERSION_INDEX) { header = smem->regions[0].virt_base;
dev_err(smem->dev, "Version item is too small\n"); versions = header->version;
return -EINVAL;
}
return le32_to_cpu(versions[SMEM_MASTER_SBL_VERSION_INDEX]); return le32_to_cpu(versions[SMEM_MASTER_SBL_VERSION_INDEX]);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment