Commit dcdd1bcb authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Greg Kroah-Hartman

iscsi_ibft: Fix missing break in switch statement

commit df997abe upstream.

Add missing break statement in order to prevent the code from falling
through to case ISCSI_BOOT_TGT_NAME, which is unnecessary.

This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.

Fixes: b33a84a3 ("ibft: convert iscsi_ibft module to iscsi boot lib")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fe34541a
...@@ -542,6 +542,7 @@ static umode_t __init ibft_check_tgt_for(void *data, int type) ...@@ -542,6 +542,7 @@ static umode_t __init ibft_check_tgt_for(void *data, int type)
case ISCSI_BOOT_TGT_NIC_ASSOC: case ISCSI_BOOT_TGT_NIC_ASSOC:
case ISCSI_BOOT_TGT_CHAP_TYPE: case ISCSI_BOOT_TGT_CHAP_TYPE:
rc = S_IRUGO; rc = S_IRUGO;
break;
case ISCSI_BOOT_TGT_NAME: case ISCSI_BOOT_TGT_NAME:
if (tgt->tgt_name_len) if (tgt->tgt_name_len)
rc = S_IRUGO; rc = S_IRUGO;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment