Commit dd8b865c authored by Baokun Li's avatar Baokun Li Committed by Paul Moore

audit: Use list_move instead of list_del/list_add

Using list_move() instead of list_del() + list_add().
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarBaokun Li <libaokun1@huawei.com>
Acked-by: default avatarRichard Guy Briggs <rgb@redhat.com>
Signed-off-by: default avatarPaul Moore <paul@paul-moore.com>
parent 619ed58a
...@@ -689,8 +689,7 @@ void audit_trim_trees(void) ...@@ -689,8 +689,7 @@ void audit_trim_trees(void)
tree = container_of(cursor.next, struct audit_tree, list); tree = container_of(cursor.next, struct audit_tree, list);
get_tree(tree); get_tree(tree);
list_del(&cursor); list_move(&cursor, &tree->list);
list_add(&cursor, &tree->list);
mutex_unlock(&audit_filter_mutex); mutex_unlock(&audit_filter_mutex);
err = kern_path(tree->pathname, 0, &path); err = kern_path(tree->pathname, 0, &path);
...@@ -899,8 +898,7 @@ int audit_tag_tree(char *old, char *new) ...@@ -899,8 +898,7 @@ int audit_tag_tree(char *old, char *new)
tree = container_of(cursor.next, struct audit_tree, list); tree = container_of(cursor.next, struct audit_tree, list);
get_tree(tree); get_tree(tree);
list_del(&cursor); list_move(&cursor, &tree->list);
list_add(&cursor, &tree->list);
mutex_unlock(&audit_filter_mutex); mutex_unlock(&audit_filter_mutex);
err = kern_path(tree->pathname, 0, &path2); err = kern_path(tree->pathname, 0, &path2);
...@@ -925,8 +923,7 @@ int audit_tag_tree(char *old, char *new) ...@@ -925,8 +923,7 @@ int audit_tag_tree(char *old, char *new)
mutex_lock(&audit_filter_mutex); mutex_lock(&audit_filter_mutex);
spin_lock(&hash_lock); spin_lock(&hash_lock);
if (!tree->goner) { if (!tree->goner) {
list_del(&tree->list); list_move(&tree->list, &tree_list);
list_add(&tree->list, &tree_list);
} }
spin_unlock(&hash_lock); spin_unlock(&hash_lock);
put_tree(tree); put_tree(tree);
...@@ -937,8 +934,7 @@ int audit_tag_tree(char *old, char *new) ...@@ -937,8 +934,7 @@ int audit_tag_tree(char *old, char *new)
tree = container_of(barrier.prev, struct audit_tree, list); tree = container_of(barrier.prev, struct audit_tree, list);
get_tree(tree); get_tree(tree);
list_del(&tree->list); list_move(&tree->list, &barrier);
list_add(&tree->list, &barrier);
mutex_unlock(&audit_filter_mutex); mutex_unlock(&audit_filter_mutex);
if (!failed) { if (!failed) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment