Commit ddcbad92 authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman

serial: icom: fix error return code

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f0c1e460
...@@ -1550,8 +1550,10 @@ static int icom_probe(struct pci_dev *dev, ...@@ -1550,8 +1550,10 @@ static int icom_probe(struct pci_dev *dev,
icom_adapter->base_addr = pci_ioremap_bar(dev, 0); icom_adapter->base_addr = pci_ioremap_bar(dev, 0);
if (!icom_adapter->base_addr) if (!icom_adapter->base_addr) {
retval = -ENOMEM;
goto probe_exit1; goto probe_exit1;
}
/* save off irq and request irq line */ /* save off irq and request irq line */
if ( (retval = request_irq(dev->irq, icom_interrupt, if ( (retval = request_irq(dev->irq, icom_interrupt,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment